Merged
Conversation
added 30 commits
June 14, 2016 14:44
…n move ctor happens [#METR-19530]
Conflicts: metrica/src/CMakeLists.txt metrica/src/ClickHouse/libs/libdaemon/include/daemon/GraphiteWriter.h metrica/src/ClickHouse/libs/libdaemon/src/GraphiteWriter.cpp metrica/src/libs/CMakeLists.txt metrica/src/libs/liblogbroker-client/src/LogBroker.cpp metrica/src/libs/liblogbroker-log-import/include/logbroker-log-import/LogBrokerLogImportTask-inl.h metrica/src/libs/libstatdaemons/include/statdaemons/write_destinations/ClickHouseCluster.h metrica/src/programs/cleanerd/src/config.xml metrica/src/programs/deduplicatord/src/Task.cpp metrica/src/programs/visit-log-processor/src/VisitLogHandler.h metrica/src/tools/ssqls/templates/header.tpl
Conflicts: metrica/src/ClickHouse/libs/libdaemon/include/daemon/GraphiteWriter.h metrica/src/ClickHouse/libs/libdaemon/src/GraphiteWriter.cpp
CMakeLists.txt
Outdated
| SET(CMAKE_EXE_LINKER_FLAGS "-static-libgcc -static-libstdc++ ${GLIBC_COMPATIBILITY_LINK_FLAGS}") | ||
|
|
||
| SET(CMAKE_CXX_FLAGS_ASAN "-O3 -g -fsanitize=address -fno-omit-frame-pointer") | ||
| SET(CMAKE_CXX_FLAGS_TSAN "-O3 -g -fsanitize=thread -fno-omit-frame-pointer") |
Member
There was a problem hiding this comment.
BTW, for thread sanitizer it is not enough, because you need to pass this flag both for compiler and linker, and also remove -static-libgcc, -static-libstdc++
And also, thread sanitizer just don't work with libstdc++ (emits false positives, tested with gcc 6).
You need either:
- rebuild libstdc++ with TSan;
- rebuild with clang;
- use libc++ instead of libstdc++.
So, this option is broken right now. Need to fix or remove.
| Self & operator=(T && rhs) { t = std::move(rhs); return *this;} | ||
|
|
||
| operator const T & () const {return t; } | ||
| operator T & () { return t; } |
Contributor
Author
There was a problem hiding this comment.
Fixed. Supported move only types like unique_ptr and types without default ctor
alexey-milovidov
pushed a commit
that referenced
this pull request
Jan 20, 2020
alexey-milovidov
pushed a commit
that referenced
this pull request
Jan 20, 2020
bkuschel
referenced
this pull request
in ClibMouse/ClickHouse
Dec 21, 2021
alexey-milovidov
pushed a commit
that referenced
this pull request
Dec 22, 2021
Onyx2406
pushed a commit
to Onyx2406/ClickHouse
that referenced
this pull request
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.