Fix potential crash in delta-kernel implementation#79677
Merged
Conversation
kssenii
added
the
pr-must-backport
Contributor
clickhouse-gh
bot
added
the
pr-bugfix
1 task
Member
Author
|
|
kssenii
commented
Apr 29, 2025
| /// So we extract these values here and put into `partitions_info`. | ||
| DB::ObjectInfoWithPartitionColumns::PartitionColumnsInfo partitions_info; | ||
| for (const auto & partition_column : context->partition_columns) | ||
| if (partition_map) |
Member
Author
There was a problem hiding this comment.
Here I only added if (partition_map) check, other diff is from the scope change. And another change is check for stat in log message below in line 286.
thevar1able
approved these changes
Apr 29, 2025
This was referenced Apr 29, 2025
robot-ch-test-poll2
added
pr-synced-to-cloud
robot-ch-test-poll
added
the
pr-backports-created
robot-clickhouse
added
the
pr-must-backport-synced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix crash in delta-kernel implementation when using unity catalog.
Documentation entry for user-facing changes