refine the exception message when keeper reaches soft memory limit#79670
refine the exception message when keeper reaches soft memory limit#79670hanfei1991 merged 3 commits intomasterfrom
Conversation
clickhouse-gh
bot
added
the
pr-not-for-changelog
GrigoryPervakov
left a comment
GrigoryPervakov
left a comment
There was a problem hiding this comment.
LGTM except failed test
hanfei1991
added
the
pr-must-backport
robot-ch-test-poll
added
the
pr-synced-to-cloud
Cherry pick #79670 to 25.4: refine the exception message when keeper reaches soft memory limit
…ches soft memory limit
Backport #79670 to 25.4: refine the exception message when keeper reaches soft memory limit
Cherry pick #79670 to 25.2: refine the exception message when keeper reaches soft memory limit
Cherry pick #79670 to 25.3: refine the exception message when keeper reaches soft memory limit
…ches soft memory limit
…ches soft memory limit
robot-clickhouse
added
the
pr-backports-created
Backport #79670 to 25.2: refine the exception message when keeper reaches soft memory limit
Backport #79670 to 25.3: refine the exception message when keeper reaches soft memory limit
robot-clickhouse
added
the
pr-must-backport-synced
|
|
||
| txn.create("/test_soft_limit/node_1000001" + str(i), b"abcde") | ||
| txn.commit() | ||
| assert "0\n" == node.query("select sum(ProfileEvent_ZooKeeperHardwareExceptions) from system.metric_log") |
There was a problem hiding this comment.
@hanfei1991 Why it should be 0? This test fails in one of my PRs, and I started to look into it, besides it does not work locally, since the session cannot be established with such small amount of RAM (no clue why it works on CI yet)
There was a problem hiding this comment.
Maybe it was 0 due to lack of missing flush, anyway - 97e95fa
There was a problem hiding this comment.
In successful runs of this test (https://s3.amazonaws.com/clickhouse-test-reports/json.html?REF=master&sha=b3f9e63ec4abb6d031ac8ec69c2c5b70238eca07&name_0=MasterCI&name_1=Integration%20tests%20%28amd_binary%2C%203%2F5%29&name_1=Integration%20tests%20%28amd_binary%2C%203%2F5%29) I see proper errors and session finalization - https://pastila.nl/?00327bbb/eb3e39880177cc4bce9665561d525081#DrLJAQtvtX6Pp3eCIJwSXA==
6 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes