Support scalar correlated subqueries in WHERE clause#79600
Merged
KochetovNicolai merged 12 commits intomasterfrom May 6, 2025
Merged
Support scalar correlated subqueries in WHERE clause#79600KochetovNicolai merged 12 commits intomasterfrom
KochetovNicolai merged 12 commits intomasterfrom
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-improvement
novikd
force-pushed
the
analyzer-correlated-scalar
branch
from
289906a to
399c9f6
Compare
novikd
changed the title
|
|
||
| void visitImpl(const QueryTreeNodePtr & node) | ||
| { | ||
| if (node->getNodeType() == QueryTreeNodeType::FUNCTION) |
Member
There was a problem hiding this comment.
It's a bit strange that we traverse scalar correlated subqueries only as a function argument.
E.g. will it work if I write select ... where (correlated sclar subquery)?
Maybe it's just better to allow query/union in needChildVisit.
KochetovNicolai
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Support scalar correlated subqueries in the WHERE clause. Closes #6697.
Documentation entry for user-facing changes