Skip to content

Support query parameters with dashes#79429

Merged
alexey-milovidov merged 5 commits intoClickHouse:masterfrom
aaaengel:issue_63093
Jun 8, 2025
Merged

Support query parameters with dashes#79429
alexey-milovidov merged 5 commits intoClickHouse:masterfrom
aaaengel:issue_63093

Conversation

@aaaengel
Copy link
Copy Markdown
Contributor

@aaaengel aaaengel commented Apr 22, 2025

Changelog category:

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Now, ClickHouse also accepts query parameters as param-<name> (dash) along with param_<name> (underscore). This closes #63093

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 22, 2025

CLA assistant check
All committers have signed the CLA.

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Apr 22, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Apr 22, 2025

Workflow [PR], commit [167b678]

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Apr 22, 2025
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test please. See tests/queries/0_stateless, .sh

@nikitamikhaylov nikitamikhaylov self-assigned this May 7, 2025
@clickhouse-gh clickhouse-gh bot added pr-improvement Pull request with some product improvements and removed pr-bugfix Pull request with bugfix, not backported by default labels May 7, 2025
@nikitamikhaylov nikitamikhaylov changed the title now it works with dash Support query parameters with dashes May 7, 2025
@alexey-milovidov alexey-milovidov merged commit 7f5f37c into ClickHouse:master Jun 8, 2025
117 of 119 checks passed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The ability to use options-with-dashes does not extend to query parameters.

6 participants