ch and clickhouse shortcuts are now responsive#79422
Closed
aaaengel wants to merge 8 commits intoClickHouse:masterfrom
Closed
ch and clickhouse shortcuts are now responsive#79422aaaengel wants to merge 8 commits intoClickHouse:masterfrom
aaaengel wants to merge 8 commits intoClickHouse:masterfrom
Conversation
|
|
alexey-milovidov
added
the
can be tested
.clang-format
Outdated
| DerivePointerAlignment: false | ||
| DisableFormat: false | ||
| IndentRequiresClause: false | ||
| #IndentRequiresClause: false |
Contributor
Author
There was a problem hiding this comment.
It was a problem locally. Will change it.
Contributor
clickhouse-gh
bot
added
the
pr-improvement
programs/main.cpp
Outdated
| /// Currently we will prefer the latter option. | ||
| std::pair<std::string_view, MainFunc> clickhouse_applications[] = | ||
| { | ||
| std::pair<std::string_view, MainFunc> clickhouse_applications[] = { |
Member
There was a problem hiding this comment.
Do not reformat the existing code.
Contributor
Author
There was a problem hiding this comment.
Oh, guess it is because clang-format command. I will provide all these changes
Member
|
Continued in #81509. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category:
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
chandclickhouseshortcuts are now responsive to--host,-h,--port,--user,-u,--passwordarguments and to connection string. When passing these arguments it runs clickhouse-client.Closes #65252