Make settings controlling connection drop on overloaded CPU hot-reloadable#79052
Merged
Algunenano merged 7 commits intomasterfrom May 21, 2025
Merged
Make settings controlling connection drop on overloaded CPU hot-reloadable#79052Algunenano merged 7 commits intomasterfrom
Algunenano merged 7 commits intomasterfrom
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-not-for-changelog
alexkats
force-pushed
the
alex-dc
branch
3 times, most recently
from
08ed875 to
fc1d26f
Compare
serxa
approved these changes
Apr 22, 2025
| /// Only for system.server_settings, actually value stored in reloader itself | ||
| std::atomic_size_t config_reload_interval_ms = ConfigReloader::DEFAULT_RELOAD_INTERVAL.count(); | ||
|
|
||
| double min_os_cpu_wait_time_ratio_to_drop_connection = 15.0; |
Member
There was a problem hiding this comment.
Why don't use the same cakes as for the settings?
Contributor
Author
There was a problem hiding this comment.
I'm not sure I understood it right, but if you mean why not use the same values as from the Settings.cpp, then the answer is those are different settings. min_os_cpu_wait_time_ratio_to_drop_connection controls connection drops, while min_os_cpu_wait_time_ratio_to_throw controls query rejection, and those should have different values
Member
|
@Algunenano, I see you have assigned to this PR. Should we merge it? It seems okay to me to merge it, but I cannot understand what the problem is with the docs check. |
Member
|
We need #80211 first because this feature can't be enabled by default. Then I'll adjust the PR |
Algunenano
added
pr-improvement
3 tasks
Member
robot-ch-test-poll
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Make settings controlling connection drop on overloaded CPU hot-reloadable