Skip to content

ci: fix "Digest does not match" for Replicated database in stress tests#79016

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
azat:rdb-digest-assert-in-stress-tests
Apr 11, 2025
Merged

ci: fix "Digest does not match" for Replicated database in stress tests#79016
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
azat:rdb-digest-assert-in-stress-tests

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Apr 11, 2025

The problem was that the tag that is added in #78741, was completely ignored by the stress tests, since it uses low-level way of running tests with Replicated database via --db-engine, let's use correct way -- --replicated-database.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes: #64936

@azat azat requested a review from tavplubix April 11, 2025 08:13
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Apr 11, 2025

Workflow [PR], commit [1b47cfc]

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 11, 2025
@tavplubix tavplubix self-assigned this Apr 11, 2025
azat added 2 commits April 11, 2025 11:57
Example:

    $ ../tests/clickhouse-test --no-random-settings --no-random-merge-tree-settings --client-option distributed_ddl_output_mode=none -- 0001_select
    ...
    00001_select_1:                                                         [ FAIL ] 0.05 sec.
    Reason: return code:  36
    Bad arguments: option '--distributed_ddl_output_mode' cannot be specified more than once
    , result:
Since --db-engine ignores the no-replicated-database tag.
@azat azat force-pushed the rdb-digest-assert-in-stress-tests branch from 4ad5ee7 to 1b47cfc Compare April 11, 2025 09:57
@alexey-milovidov alexey-milovidov merged commit 0cd6cc2 into ClickHouse:master Apr 11, 2025
113 of 122 checks passed
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replicated database engine: Assert checkDigestValid

4 participants