Conversation
Contributor
clickhouse-gh
bot
added
the
pr-improvement
al13n321
commented
Apr 11, 2025
rschu1ze
approved these changes
Apr 13, 2025
robot-ch-test-poll4
added
the
pr-synced-to-cloud
rienath
added
the
pr-must-backport
This was referenced Jun 23, 2025
robot-ch-test-poll4
added a commit
that referenced
this pull request
Jun 23, 2025
Cherry pick #79008 to 25.3: Fix hashing of NULLs, attempt 3
robot-clickhouse
added a commit
that referenced
this pull request
Jun 23, 2025
This was referenced Jun 23, 2025
robot-ch-test-poll4
added a commit
that referenced
this pull request
Jun 23, 2025
Cherry pick #79008 to 25.4: Fix hashing of NULLs, attempt 3
robot-clickhouse
added a commit
that referenced
this pull request
Jun 23, 2025
robot-clickhouse-ci-2
added
the
pr-backports-created-cloud
robot-ch-test-poll4
added
the
pr-backports-created
rienath
added a commit
that referenced
this pull request
Jun 23, 2025
Backport #79008 to 25.3: Fix hashing of NULLs, attempt 3
rienath
added a commit
that referenced
this pull request
Jun 23, 2025
Backport #79008 to 25.4: Fix hashing of NULLs, attempt 3
robot-clickhouse
added
the
pr-must-backport-synced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Hash functions now support NULLs inside arrays, tuples, and maps. (issues #48365 and #48623)
Documentation entry for user-facing changes
Closes #48365
Closes #48623
Based on #58754 , which was based on #48625 . Hopefully this one will make it, this seems really useful for tests.
This shouldn't break compatibility because it only affects queries that would previously fail (refusing to hash an array/tuple/map with Nullable inside).
The somewhat error-prone behavior
hash(null, ...) == nullremains, but is easy to work around usinghash(tuple(...)).