Conversation
Member
Author
|
No ideas right now about the fuzzer failures. My understanding is that it's not my bug, but the added test helps fuzzer to trigger this error now. To confirm I created another pr on top of the master with the new test as the only change. Also trying to catch it locally. |
Member
Author
|
|
robot-ch-test-poll4
added a commit
that referenced
this pull request
Jun 16, 2025
Cherry pick #78694 to 25.6: Optimize replica-initiator communication in distributed queries
alexey-milovidov
added a commit
that referenced
this pull request
Jun 17, 2025
Backport #78694 to 25.6: Optimize replica-initiator communication in distributed queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Introduced an option to offload (de)compression and (de)serialization of blocks into pipeline threads instead of a single thread associated with a network connection. Controlled by the setting
enable_parallel_blocks_marshalling. It should speed up distributed queries that transfer significant amounts of data between the initiator and remote nodes.A few comments on the implementation:
ClickHouse/src/Processors/QueryPlan/BlocksMarshallingStep.cpp
Lines 37 to 43 in f938b9a
ClickHouse/src/Columns/ColumnBLOB.h
Lines 97 to 110 in f938b9a
TCPHandler, there is a new serialization typeSerializationDetached. It does nothing except copies an already marshalled BLOB in/out of socketClickHouse/src/Processors/Sources/RemoteSource.cpp
Lines 294 to 304 in f938b9a
Examples:
Before:
After: