Skip to content

Minor refactoring near AlterConversions#78515

Merged
CurtizJ merged 3 commits intoClickHouse:masterfrom
CurtizJ:alter-conversions-refactoring
Apr 4, 2025
Merged

Minor refactoring near AlterConversions#78515
CurtizJ merged 3 commits intoClickHouse:masterfrom
CurtizJ:alter-conversions-refactoring

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Apr 1, 2025

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Required for lightweight updates.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Apr 1, 2025

Workflow [PR], commit [bab469d]

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 1, 2025
@Avogar Avogar self-assigned this Apr 1, 2025
@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Apr 4, 2025

Fuzzer: #78542.
Integration test: test_ssh/test.py::test_no_queries_from_file is not related.

@CurtizJ CurtizJ added this pull request to the merge queue Apr 4, 2025
Merged via the queue into ClickHouse:master with commit bf4a033 Apr 4, 2025
115 of 119 checks passed
@CurtizJ CurtizJ deleted the alter-conversions-refactoring branch April 4, 2025 11:35
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 4, 2025
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Apr 5, 2025
baibaichen pushed a commit to apache/gluten that referenced this pull request Apr 5, 2025
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250405)

* Fix Build due to ClickHouse/ClickHouse#78515

* remove temp code due to #9192

* Fix test fail due to ClickHouse/ClickHouse#78022

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang chen <[email protected]>
azat added a commit to azat/ClickHouse that referenced this pull request Apr 5, 2025
Request it only if those columns has been requested.

Note, that the main motivation was to fix private CI, since for SMT one
of the tests fails.

Fixes: ClickHouse#78515
@azat
Copy link
Copy Markdown
Member

azat commented Apr 5, 2025

CH Inc sync failed for a reason, the fix is here - #78720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants