Skip to content

Fix prefetch of substreams with prefixes in Wide parts#78205

Merged
Avogar merged 4 commits intomasterfrom
Avogar-patch-8
Apr 1, 2025
Merged

Fix prefetch of substreams with prefixes in Wide parts#78205
Avogar merged 4 commits intomasterfrom
Avogar-patch-8

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Mar 24, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix prefetch of substreams with prefixes in Wide parts

Was intoroduced in #77640

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 24, 2025

Workflow [PR], commit [6ef4b9b]

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Mar 24, 2025
@devcrafter
Copy link
Copy Markdown
Member

Can we have a specific test for it?

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Mar 24, 2025

I couldn't create a stable reproducer, it depends on which merge tree reader will start prefixes deserialization first (they do it concurrently).
I reproduced it by running test 02943_variant_type_with_different_local_and_global_order multiple times concurrently.

@SmitaRKulkarni SmitaRKulkarni self-assigned this Mar 29, 2025
@SmitaRKulkarni
Copy link
Copy Markdown
Member

@Avogar : Maybe it helps to run flaky check in CI on 02943_variant_type_with_different_local_and_global_order

Rest all LGTM

@Avogar Avogar enabled auto-merge April 1, 2025 12:23
@Avogar Avogar added this pull request to the merge queue Apr 1, 2025
Merged via the queue into master with commit 669aabd Apr 1, 2025
115 of 123 checks passed
@Avogar Avogar deleted the Avogar-patch-8 branch April 1, 2025 12:53
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 1, 2025
robot-clickhouse added a commit that referenced this pull request Apr 1, 2025
Cherry pick #78205 to 25.3: Fix prefetch of substreams with prefixes in Wide parts
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Apr 1, 2025
alexey-milovidov added a commit that referenced this pull request Apr 2, 2025
Backport #78205 to 25.3: Fix prefetch of substreams with prefixes in Wide parts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants