Skip to content

Enable query condition cache by default#77983

Closed
alexey-milovidov wants to merge 2 commits intomasterfrom
fix-query-condition-cache
Closed

Enable query condition cache by default#77983
alexey-milovidov wants to merge 2 commits intomasterfrom
fix-query-condition-cache

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Mar 20, 2025

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Enabled the query condition cache by default.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 20, 2025

Workflow [PR], commit [f3613e1]

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 20, 2025
@serxa serxa self-assigned this Mar 20, 2025
@rschu1ze rschu1ze changed the title Remove garbage from the query condition cache and enable it by default Enable query condition cache by default + un-trash it a little bit Apr 2, 2025
@alexey-milovidov
Copy link
Copy Markdown
Member Author

01167_isolation_hermitage needs attention.
About performance tests - we should disable the cache for them.

@Algunenano

This comment was marked as resolved.

@rschu1ze rschu1ze force-pushed the fix-query-condition-cache branch from 38b8f1d to e84f11a Compare April 11, 2025 12:45
@clickhouse-gh clickhouse-gh bot added pr-improvement Pull request with some product improvements and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Apr 11, 2025
@rschu1ze rschu1ze changed the title Enable query condition cache by default + un-trash it a little bit Enable query condition cache by default Apr 11, 2025
@alexey-milovidov
Copy link
Copy Markdown
Member Author

@rschu1ze, after your changes, it is not enabled by default in this pull request.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

And you have lost my commits :(

@alexey-milovidov
Copy link
Copy Markdown
Member Author

#79080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants