Save marks for each substream in Compact part to be able to read individual subcolumns#77940
Merged
Avogar merged 24 commits intoClickHouse:masterfrom Apr 23, 2025
Merged
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-performance
alexey-milovidov
changed the title
Member
Author
🔥
|
Member
Author
|
Let's try to include it in 25.4 release if possible |
CurtizJ
reviewed
Apr 11, 2025
| This mode allows to use significantly less memory for storing discriminators | ||
| in parts when there is mostly one variant or a lot of NULL values. | ||
| )", 0) \ | ||
| DECLARE(Bool, write_marks_for_substreams_in_compact_parts, true, R"( |
Member
There was a problem hiding this comment.
Maybe set to false by default in the first supported release to allow rollback from it.
Member
Author
There was a problem hiding this comment.
Won't compatibility setting be enough? For services with old compatibility setting we will have this disabled by default.
Member
Author
|
@CurtizJ did you have a chance to check changes in the sync as well? |
Member
|
Yes, I checked the changes in sync. They are ok as well. |
Merged
via the queue into
ClickHouse:master
with commit Apr 23, 2025
de8d34d
116 of 121 checks passed
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Apr 24, 2025
It introduces columns_substreams.txt for MergeTree's compact mode, causing test failures as both increased file sizes and additional file count alter compaction patterns compared to prior implementations. Changes: - Updated file counting logic to exclude the new "columns_substreams.txt" - Updated comments with correct file sizes and improved clarity - Updated hardcoded config strings to use DeltaSQLConf constants
baibaichen
added a commit
to apache/gluten
that referenced
this pull request
Apr 24, 2025
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250424) * Fix ut due to ClickHouse/ClickHouse#77940 It introduces columns_substreams.txt for MergeTree's compact mode, causing test failures as both increased file sizes and additional file count alter compaction patterns compared to prior implementations. Changes: - Updated file counting logic to exclude the new "columns_substreams.txt" - Updated comments with correct file sizes and improved clarity - Updated hardcoded config strings to use DeltaSQLConf constants --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang chen <[email protected]>
56 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Change the Compact part format to save marks for each substream to be able to read individual subcolumns. Old Compact format is still supported for reads and can be enabled for writes using MergeTree setting
write_marks_for_substreams_in_compact_parts. It's disabled by default for safer upgrades as it changes the compact parts storage. It will be enabled by default in one of the next releases.Closes #76141
Documentation entry for user-facing changes