Skip to content

Fix PODArray.insert#7791

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
DimasKovas:fix_insert_in_pod_array
Nov 17, 2019
Merged

Fix PODArray.insert#7791
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
DimasKovas:fix_insert_in_pod_array

Conversation

@DimasKovas
Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Fix the case where PODArray.insert works with iterator after invalidation.

@DimasKovas
Copy link
Copy Markdown
Contributor Author

I didn't find any usages of PODArray.insert with 3 iterators in the code base. Nothing is affected by this PR yet.

@alexey-milovidov alexey-milovidov merged commit 06b9466 into ClickHouse:master Nov 17, 2019
@nikitamikhaylov nikitamikhaylov added the pr-bugfix Pull request with bugfix, not backported by default label Dec 2, 2019
nikitamikhaylov pushed a commit that referenced this pull request Dec 2, 2019
Fix PODArray.insert

(cherry picked from commit 06b9466)
nikitamikhaylov pushed a commit that referenced this pull request Dec 2, 2019
Fix PODArray.insert

(cherry picked from commit 06b9466)
nikitamikhaylov pushed a commit that referenced this pull request Dec 2, 2019
Fix PODArray.insert

(cherry picked from commit 06b9466)
vitlibar pushed a commit that referenced this pull request Dec 26, 2019
Fix PODArray.insert

(cherry picked from commit 06b9466)
xinyiZzz added a commit to apache/doris that referenced this pull request Jun 3, 2024
1. Add PODArray ut
2. pick ClickHouse/ClickHouse#21533
3. pick ClickHouse/ClickHouse#21678
4. pick ClickHouse/ClickHouse#9498
5. pick ClickHouse/ClickHouse#7791
6. pick ClickHouse/ClickHouse#24271
7. if c_end_of_storage == null, allocated_bytes return 0.
8. Add some checks for DEBUG.
9. TODO: Adapt internal data structures to 512-bit era
ClickHouse/ClickHouse#42564
dataroaring pushed a commit to apache/doris that referenced this pull request Jun 4, 2024
1. Add PODArray ut
2. pick ClickHouse/ClickHouse#21533
3. pick ClickHouse/ClickHouse#21678
4. pick ClickHouse/ClickHouse#9498
5. pick ClickHouse/ClickHouse#7791
6. pick ClickHouse/ClickHouse#24271
7. if c_end_of_storage == null, allocated_bytes return 0.
8. Add some checks for DEBUG.
9. TODO: Adapt internal data structures to 512-bit era
ClickHouse/ClickHouse#42564
seawinde pushed a commit to seawinde/doris that referenced this pull request Jun 5, 2024
1. Add PODArray ut
2. pick ClickHouse/ClickHouse#21533
3. pick ClickHouse/ClickHouse#21678
4. pick ClickHouse/ClickHouse#9498
5. pick ClickHouse/ClickHouse#7791
6. pick ClickHouse/ClickHouse#24271
7. if c_end_of_storage == null, allocated_bytes return 0.
8. Add some checks for DEBUG.
9. TODO: Adapt internal data structures to 512-bit era
ClickHouse/ClickHouse#42564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants