Support atomic rename when TRUNCATE is used with INTO OUTFILE#77181
Merged
pamarcos merged 8 commits intoClickHouse:masterfrom Mar 7, 2025
Merged
Support atomic rename when TRUNCATE is used with INTO OUTFILE#77181pamarcos merged 8 commits intoClickHouse:masterfrom
pamarcos merged 8 commits intoClickHouse:masterfrom
Conversation
bharatnc
added
the
can be tested
Contributor
clickhouse-gh
bot
added
the
pr-improvement
pamarcos
reviewed
Mar 6, 2025
Member
There was a problem hiding this comment.
Great work! I think overall is en elegant solution that addresses the problem 🚀
I left some minor nitpick comments with what I found.
For the CHANGELOG entry I think we should write a shorter and more straightforward thing. Something more in line with the title of this PR is ok.
Also, please merge latest master against your branch, because we upgraded some submodules recently and testing on our local machines takes more time the more it deviates from master 🙏
tests/queries/0_stateless/03362_into_outfile_atomic_truncate.sh
Outdated
Show resolved
Hide resolved
tests/queries/0_stateless/03362_into_outfile_atomic_truncate.sh
Outdated
Show resolved
Hide resolved
tests/queries/0_stateless/03362_into_outfile_atomic_truncate.sh
Outdated
Show resolved
Hide resolved
tests/queries/0_stateless/03362_into_outfile_atomic_truncate.sh
Outdated
Show resolved
Hide resolved
Contributor
Author
Merged
via the queue into
ClickHouse:master
with commit Mar 7, 2025
9612f6a
122 of 125 checks passed
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
|
|
||
| bool isSpecialFile(const String & path) | ||
| { | ||
| return path == "/dev/null" || path == "/dev/stdout" || path == "/dev/stderr"; |
Member
|
@pamarcos, this does not work at all: |
Member
No. |
1 task
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Support atomic rename when
TRUNCATEis used withINTO OUTFILE. Resolves #70323.Documentation entry for user-facing changes