Fix logical error while using query_plan_join_swap_table#76722
Merged
alexey-milovidov merged 3 commits intomasterfrom Feb 26, 2025
Merged
Fix logical error while using query_plan_join_swap_table#76722alexey-milovidov merged 3 commits intomasterfrom
alexey-milovidov merged 3 commits intomasterfrom
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-not-for-changelog
vdimir
force-pushed
the
vdimir/join_multiple_swap_iss76642
branch
from
f2b6487 to
61d54f6
Compare
vdimir
commented
Feb 25, 2025
| result_node.step = std::make_unique<FilterStep>(new_join_node.step->getOutputHeader(), std::move(*join_expression_actions.post_join_actions), post_filter.getColumnName(), remove_filter); | ||
| result_node.children = {&new_join_node}; | ||
| } | ||
| else if (!isPassthroughActions(*join_expression_actions.post_join_actions)) |
Member
Author
There was a problem hiding this comment.
These actions are required to restore the proper column order. ExpressionStep can handle this, but when there are two consecutive JoinSteps and the headers are messed up, it results in an error.
nikitamikhaylov
approved these changes
Feb 25, 2025
robot-ch-test-poll2
added
the
pr-synced-to-cloud
robot-ch-test-poll1
added a commit
that referenced
this pull request
Feb 26, 2025
Cherry pick #76722 to 25.2: Fix logical error while using query_plan_join_swap_table
robot-clickhouse
added a commit
that referenced
this pull request
Feb 26, 2025
robot-clickhouse
added
the
pr-backports-created
robot-ch-test-poll3
added a commit
that referenced
this pull request
Feb 26, 2025
Backport #76722 to 25.2: Fix logical error while using query_plan_join_swap_table
robot-clickhouse
added
the
pr-must-backport-synced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
bug in unreleased 25.2 close #76642
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes