Skip to content

Add performance tests for null shortcuit and fix bugs#76708

Merged
yariks5s merged 2 commits intoClickHouse:masterfrom
bigo-sg:improve_short_circuit_nulls
Mar 3, 2025
Merged

Add performance tests for null shortcuit and fix bugs#76708
yariks5s merged 2 commits intoClickHouse:masterfrom
bigo-sg:improve_short_circuit_nulls

Conversation

@taiyang-li
Copy link
Copy Markdown
Contributor

@taiyang-li taiyang-li commented Feb 25, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add performance tests for null shortcuit and fix bugs

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Feb 25, 2025

Workflow [PR], commit [656c808]

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Feb 25, 2025
@yariks5s yariks5s self-assigned this Feb 25, 2025
Copy link
Copy Markdown
Member

@yariks5s yariks5s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pull request contains a bug fix, could you please write a test that reproduces this bug? I've changed the PR type to bugfix

@taiyang-li
Copy link
Copy Markdown
Contributor Author

taiyang-li commented Mar 1, 2025

If this pull request contains a bug fix, could you please write a test that reproduces this bug? I've changed the PR type to bugfix

I think the newly added perf test could reproduce the bug. That't why it failed with master branch...

@yariks5s yariks5s added this pull request to the merge queue Mar 3, 2025
Merged via the queue into ClickHouse:master with commit bc17b25 Mar 3, 2025
121 of 124 checks passed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants