tests: limit memory usage for tests#76388
Closed
azat wants to merge 1 commit intoClickHouse:masterfrom
Closed
Conversation
Contributor
alexey-milovidov
approved these changes
Feb 18, 2025
Member
alexey-milovidov
left a comment
alexey-milovidov
left a comment
There was a problem hiding this comment.
This is great! Can we also set up limits on the number of processes and opened files? (they can be set to a reasonably high value).
Member
Author
|
I guess this make sense as well, though I would not expect them to be huge right now. What I really think make sense is to implement them as cgroups, to limit the memory properly over limiting address space. |
To avoid situation when the tests eats too much RAM and we spend dozen of time to figure out why MEMORY_LIMIT_EXCEEDED happens on the server. Refs: ClickHouse#75966
azat
force-pushed
the
tests/limit-memory
branch
from
887a843 to
05a9015
Compare
|
|
||
| def prlimit(command, limit): | ||
| """Limit memory usage for each test to avoid MEMORY_LIMIT_EXCEEDED errors on server""" | ||
| return f"prlimit --as={limit} {command}" |
Member
There was a problem hiding this comment.
There is the --rss option.
Member
Author
There was a problem hiding this comment.
This is rudiment, here is a snippet from man page:
RLIMIT_RSS
Specifies the limit (in pages) of the process's resident set (the number of virtual pages resident in RAM). This limit only has effect in Linux 2.4.x, x < 30, and there only affects calls to [madvise](https://linux.die.net/man/2/madvise)(2) specifying MADV_WILLNEED
| if batch_num and batch_total: | ||
| aux = f"--run-by-hash-total {batch_total} --run-by-hash-num {batch_num-1}" | ||
| statless_test_command = f"clickhouse-test --testname --shard --zookeeper --check-zookeeper-session --hung-check --print-time \ | ||
| statless_test_command = f"clickhouse-test --memory-limit {20<<30} --testname --shard --zookeeper --check-zookeeper-session --hung-check --print-time \ |
Member
There was a problem hiding this comment.
We don't have to expose these settings, hardcoding is ok.
Member
There was a problem hiding this comment.
However, due to the comment above, this is likely to not work with sanitizers, so let's keep it.
Contributor
|
Dear @azat, this PR hasn't been updated for a while. Will you continue working on it? If not, please close it. Otherwise, ignore this message. |
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jun 22, 2025
Jobs with sanitizers shows lots of OOM, last time (ClickHouse#76143) it happened due to some test spawns tons of clients, and sanitizer binary takes 650MiB each in RAM Refs: ClickHouse#82036 Resubmit of: ClickHouse#76388
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jun 22, 2025
Jobs with sanitizers shows lots of OOM, last time (ClickHouse#76143) it happened due to some test spawns tons of clients, and sanitizer binary takes 650MiB each in RAM This is resubmit of ClickHouse#76388, which did not work because address space limit, which is way different thing, especially for the binaries built with sanitizers Refs: ClickHouse#82036
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jun 22, 2025
Jobs with sanitizers shows lots of OOM, last time (ClickHouse#76143) it happened due to some test spawns tons of clients, and sanitizer binary takes 650MiB each in RAM This is resubmit of ClickHouse#76388, which did not work because address space limit, which is way different thing, especially for the binaries built with sanitizers Refs: ClickHouse#82036
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jun 22, 2025
Jobs with sanitizers shows lots of OOM, last time (ClickHouse#76143) it happened due to some test spawns tons of clients, and sanitizer binary takes 650MiB each in RAM This is resubmit of ClickHouse#76388, which did not work because address space limit, which is way different thing, especially for the binaries built with sanitizers Refs: ClickHouse#82036
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jun 22, 2025
Jobs with sanitizers shows lots of OOM, last time (ClickHouse#76143) it happened due to some test spawns tons of clients, and sanitizer binary takes 650MiB each in RAM This is resubmit of ClickHouse#76388, which did not work because address space limit, which is way different thing, especially for the binaries built with sanitizers Refs: ClickHouse#82036
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jun 22, 2025
Jobs with sanitizers shows lots of OOM, last time (ClickHouse#76143) it happened due to some test spawns tons of clients, and sanitizer binary takes 650MiB each in RAM This is resubmit of ClickHouse#76388, which did not work because address space limit, which is way different thing, especially for the binaries built with sanitizers Refs: ClickHouse#82036
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jun 23, 2025
Jobs with sanitizers shows lots of OOM, last time (ClickHouse#76143) it happened due to some test spawns tons of clients, and sanitizer binary takes 650MiB each in RAM This is resubmit of ClickHouse#76388, which did not work because address space limit, which is way different thing, especially for the binaries built with sanitizers Refs: ClickHouse#82036
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jan 1, 2026
Jobs with sanitizers shows lots of OOM, last time (ClickHouse#76143) it happened due to some test spawns tons of clients, and sanitizer binary takes 650MiB each in RAM This is resubmit of ClickHouse#76388, which did not work because address space limit, which is way different thing, especially for the binaries built with sanitizers Refs: ClickHouse#82036 v2: use cgroup v2
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jan 1, 2026
Jobs with sanitizers shows lots of OOM, last time (ClickHouse#76143) it happened due to some test spawns tons of clients, and sanitizer binary takes 650MiB each in RAM This is resubmit of ClickHouse#76388, which did not work because address space limit, which is way different thing, especially for the binaries built with sanitizers Refs: ClickHouse#82036 v2: use cgroup v2
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jan 1, 2026
Jobs with sanitizers shows lots of OOM, last time (ClickHouse#76143) it happened due to some test spawns tons of clients, and sanitizer binary takes 650MiB each in RAM This is resubmit of ClickHouse#76388, which did not work because address space limit, which is way different thing, especially for the binaries built with sanitizers Refs: ClickHouse#82036 v2: use cgroup v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: for now in draft, since likely there will be some issues
To avoid situation when the tests eats too much RAM and we spend dozen of time to figure out why MEMORY_LIMIT_EXCEEDED happens on the server.
Refs: #75966
Changelog category (leave one):