tests: fix 02597_column_* flakiness#76345
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Feb 22, 2025
Merged
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-not-for-changelog
davenger
approved these changes
Feb 18, 2025
azat
force-pushed
the
tests/02597_column_delete_and_replication
branch
from
4614e13 to
1226c20
Compare
- use throwIf() + KILL MUTATION over sleep() - disable for SMT - it checks completelly different there, note that 02597_column_update_tricky_expression_and_replication was not even tested due to test-in-test architecture of the test. Refs: ClickHouse#74798 (@nickitat) Refs: ClickHouse#74826 (reverts it back) Refs: ClickHouse#50181 Fixes: ClickHouse#58799
azat
force-pushed
the
tests/02597_column_delete_and_replication
branch
from
1226c20 to
40041a3
Compare
azat
changed the title
Member
Author
|
@KochetovNicolai or @alesapin can you PTAL? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changes
02597_column_update_tricky_expression_and_replication was not even
tested due to script-in-script architecture of the test.
Refs: #74798 (@nickitat)
Refs: #74826 (reverts it back)
Refs: #50181 (@KochetovNicolai @alesapin)
Refs: #67873 (@thevar1able)
Fixes: #58799