Improved the display of tuples in Pretty format, #65388#76184
Open
krutik2966 wants to merge 4 commits intoClickHouse:masterfrom
Open
Improved the display of tuples in Pretty format, #65388#76184krutik2966 wants to merge 4 commits intoClickHouse:masterfrom
krutik2966 wants to merge 4 commits intoClickHouse:masterfrom
Conversation
|
|
krutik2966
force-pushed
the
issue-65388
branch
2 times, most recently
from
de002a7 to
b9eb084
Compare
krutik2966
force-pushed
the
issue-65388
branch
from
1708221 to
ab59fc0
Compare
alexey-milovidov
changed the title
alexey-milovidov
added
the
can be tested
Contributor
clickhouse-gh
bot
added
the
pr-improvement
| │ check_system_tables │ name2 │ name1 │ name1 │ name1 │ default │ 0 │ | ||
| └─────────────────────┴───────────────┴─────────────┴─────────────┴──────────────┴────────────────┴────────────┘ | ||
| ┌─name──┬─is_in_partition_key─┬─is_in_sorting_key─┬─is_in_primary_key─┬─is_in_sampling_key─┐ | ||
| ├───────┼─────────────────────┼───────────────────┼───────────────────┼────────────────────┤ |
Member
There was a problem hiding this comment.
This result does not have tuples, but still has changed. This does not look right.
| ┏━━━━━━━━━━━━━━━━━━━━━━┓ | ||
| ┃ [1mCAST('true', 'Bool')[0m ┃ | ||
| ┣━━━━━━━━━━━━━━━━━━━━━━┫ | ||
| ┃ ┃ |
Member
There was a problem hiding this comment.
This empty space is not what we needed.
Author
There was a problem hiding this comment.
Thanks for the review! I will make the necessary changes.
alexey-milovidov
removed
the
can be tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Improved the display of tuples in Pretty format to show elements as subcolumns, preserving the hierarchy in the header for better readability. Closes #65388.
Documentation entry for user-facing changes
Motivation: The new output format for tuples in Pretty formats improves the readability of query results by displaying tuple elements as subcolumns with clear headers, making it easier for users to interpret complex nested structures.
Example usage :