Follow-up to #75470, #75756, #66143, #75671#76082
Merged
rschu1ze merged 5 commits intoClickHouse:masterfrom Feb 17, 2025
Merged
Follow-up to #75470, #75756, #66143, #75671#76082rschu1ze merged 5 commits intoClickHouse:masterfrom
rschu1ze merged 5 commits intoClickHouse:masterfrom
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-not-for-changelog
Member
Author
|
@Blargian We can utilize utils/check-style/check-style to implement automatic style checks. |
novikd
reviewed
Feb 13, 2025
Comment on lines
+4303
to
+4304
| Accepts DateTime and DateTime64 as 'StartTime' argument. For DateTime, 'Duration' and 'Size' arguments must be `UInt32`. For 'DateTime64' they must be `Decimal64`. | ||
| Returns an array of DateTime/DateTime64 (return type matches the type of 'StartTime'). For DateTime64, the return value's scale can differ from the scale of 'StartTime' --- the highest scale among all given arguments is taken. |
Member
There was a problem hiding this comment.
Suggested change
| Accepts DateTime and DateTime64 as 'StartTime' argument. For DateTime, 'Duration' and 'Size' arguments must be `UInt32`. For 'DateTime64' they must be `Decimal64`. | |
| Returns an array of DateTime/DateTime64 (return type matches the type of 'StartTime'). For DateTime64, the return value's scale can differ from the scale of 'StartTime' --- the highest scale among all given arguments is taken. | |
| Accepts `DateTime` and `DateTime64` as 'StartTime' argument. For `DateTime`, 'Duration' and 'Size' arguments must be `UInt32`. For `DateTime64`, they must be `Decimal64`. | |
| Returns an array of `DateTime` or `DateTime64` (return type matches the type of 'StartTime'). For `DateTime64`, the return value's scale can differ from the scale of 'StartTime' --- the highest scale among all given arguments is taken. |
Member
Author
There was a problem hiding this comment.
The point of this PR is to get rid of non-standard quotation marks, see my changes in utils/check-style/check-style.
| "Павел Литвиненко", | ||
| "Смитюх Вячеслав", | ||
| "Сундуков Алексей", | ||
| "“JiaQi", |
Member
Author
There was a problem hiding this comment.
I guess “ was there by accident ...
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
ClickHouse:master
with commit Feb 17, 2025
4722e90
120 of 127 checks passed
robot-ch-test-poll
added
the
pr-synced-to-cloud
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):