Skip to content

Calculate columns and indices sizes lazily in MergeTree#75938

Merged
Avogar merged 9 commits intoClickHouse:masterfrom
Avogar:calculate-sizes-lazily
Feb 14, 2025
Merged

Calculate columns and indices sizes lazily in MergeTree#75938
Avogar merged 9 commits intoClickHouse:masterfrom
Avogar:calculate-sizes-lazily

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Feb 11, 2025

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Calculate columns and indices sizes lazily in MergeTree.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Feb 11, 2025

Workflow [PR], commit [4c37ea9]

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Feb 11, 2025
@serxa serxa self-assigned this Feb 11, 2025
Copy link
Copy Markdown
Member

@serxa serxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a test. But I actually don't know how such a test could be done, because it is just a performance improvement

@Avogar Avogar added this pull request to the merge queue Feb 14, 2025
Merged via the queue into ClickHouse:master with commit ef6919c Feb 14, 2025
115 of 116 checks passed
@Avogar Avogar deleted the calculate-sizes-lazily branch February 14, 2025 17:26
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 14, 2025
baibaichen added a commit to Kyligence/gluten that referenced this pull request Feb 15, 2025
baibaichen added a commit to apache/gluten that referenced this pull request Feb 15, 2025
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250215)

* Fix build due to ClickHouse/ClickHouse#75938

* Fix Ut due to ClickHouse/ClickHouse#74827

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
baibaichen added a commit to apache/gluten that referenced this pull request Feb 20, 2025
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250220)

* Fix build due to ClickHouse/ClickHouse#75474

* Fix build due to ClickHouse/ClickHouse#75452

* Rework "gluten_cache.local.enabled" config due to ClickHouse/ClickHouse#75452

Now, we still use "gluten_cache.local.enabled" in spark, and we will convert it to "enable.gluten_cache.local" when initlize native backend.

* Fix memory access error exposed by ClickHouse/ClickHouse#75452

* Fix  "<Error>... Possibly incorrect column size subtraction" due to  ClickHouse/ClickHouse#75938

* Unified temporary directory

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
kevinw66 pushed a commit to kevinw66/incubator-gluten that referenced this pull request Mar 3, 2025
)

* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250215)

* Fix build due to ClickHouse/ClickHouse#75938

* Fix Ut due to ClickHouse/ClickHouse#74827

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
kevinw66 pushed a commit to kevinw66/incubator-gluten that referenced this pull request Mar 3, 2025
)

* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250220)

* Fix build due to ClickHouse/ClickHouse#75474

* Fix build due to ClickHouse/ClickHouse#75452

* Rework "gluten_cache.local.enabled" config due to ClickHouse/ClickHouse#75452

Now, we still use "gluten_cache.local.enabled" in spark, and we will convert it to "enable.gluten_cache.local" when initlize native backend.

* Fix memory access error exposed by ClickHouse/ClickHouse#75452

* Fix  "<Error>... Possibly incorrect column size subtraction" due to  ClickHouse/ClickHouse#75938

* Unified temporary directory

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants