Skip to content

Made mutation to choose the same disk in ReplicatedMergeTree.#7558

Merged
alesapin merged 3 commits intoClickHouse:masterfrom
excitoon:patch-1
Nov 1, 2019
Merged

Made mutation to choose the same disk in ReplicatedMergeTree.#7558
alesapin merged 3 commits intoClickHouse:masterfrom
excitoon:patch-1

Conversation

@excitoon
Copy link
Copy Markdown
Contributor

@excitoon excitoon commented Oct 31, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Bug Fix

Short description (up to few sentences):

Fixed bug with hardlinks failing to be created during mutations in ReplicatedMergeTree in multi-disk configurations.

@alesapin alesapin added the pr-bugfix Pull request with bugfix, not backported by default label Oct 31, 2019
Copy link
Copy Markdown
Member

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexey-milovidov
Copy link
Copy Markdown
Member

Bad description for changelog. It doesn't describe the bug that was fixed (I can guess, but we need to make good description for user).

Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comment.

@excitoon
Copy link
Copy Markdown
Contributor Author

Missing comment.

Fixed both.

@alesapin alesapin merged commit 6ef0a92 into ClickHouse:master Nov 1, 2019
@excitoon excitoon deleted the patch-1 branch November 4, 2019 14:46
alesapin added a commit that referenced this pull request Nov 11, 2019
Made mutation to choose the same disk in `ReplicatedMergeTree`.
alexey-milovidov added a commit that referenced this pull request Nov 21, 2019
Fixed errors with space reservation introduced in #7558 and #7602
tavplubix pushed a commit that referenced this pull request Nov 21, 2019
Fixed errors with space reservation introduced in #7558 and #7602
tavplubix pushed a commit that referenced this pull request Nov 21, 2019
Fixed errors with space reservation introduced in #7558 and #7602
tavplubix pushed a commit that referenced this pull request Nov 21, 2019
Fixed errors with space reservation introduced in #7558 and #7602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants