Skip to content

Fix PREWHERE with constant condition and tables with non-adaptive graularity#75270

Merged
maxknv merged 5 commits intoClickHouse:masterfrom
CurtizJ:fix-const-prewhere
Feb 2, 2025
Merged

Fix PREWHERE with constant condition and tables with non-adaptive graularity#75270
maxknv merged 5 commits intoClickHouse:masterfrom
CurtizJ:fix-const-prewhere

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Jan 30, 2025 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes #56640
Fixes #62741
Fixes #74472

CI Settings (Only check the boxes if you know what you are doing)

All builds in Builds_1 and Builds_2 stages are always mandatory and will run independently of the checks below:

  • Only: Stateless tests
  • Only: Integration tests
  • Only: Performance tests
  • Skip: Style check
  • Skip: Fast test
  • Run all checks ignoring all possible failures (Resource-intensive. All test jobs execute in parallel).
  • Disable CI cache

@CurtizJ CurtizJ changed the title Fix PRWHERE with constant condition and tables with non-adaptive graularity Fix PREWHERE with constant condition and tables with non-adaptive graularity Jan 30, 2025
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 30, 2025
@CurtizJ CurtizJ mentioned this pull request Jan 30, 2025
Closed
22 tasks
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Jan 30, 2025 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit c7a3306 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (asan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (debug)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (msan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (tsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (ubsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns ClickBench with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@CurtizJ CurtizJ added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jan 30, 2025
@CurtizJ CurtizJ force-pushed the fix-const-prewhere branch from 28a070b to 6e1e585 Compare January 30, 2025 17:07
@devcrafter devcrafter self-assigned this Jan 30, 2025
devcrafter
devcrafter reviewed Jan 30, 2025
View reviewed changes
@qoega
Copy link
Copy Markdown
Member

qoega commented Jan 30, 2025

checked that test was failing on master https://fiddle.clickhouse.com/4f294a1c-091e-40ec-bf42-6cb31c2e92f1

@devcrafter
Copy link
Copy Markdown
Member

devcrafter commented Jan 30, 2025

checked that test was failing on master fiddle.clickhouse.com/4f294a1c-091e-40ec-bf42-6cb31c2e92f1

It was done here - https://s3.amazonaws.com/clickhouse-test-reports/74472/c0055e116c0a26b8ed22d3b7403450116e5f01de/fast_test.html

@CurtizJ CurtizJ added this pull request to the merge queue Feb 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 1, 2025
@CurtizJ CurtizJ added this pull request to the merge queue Feb 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 1, 2025
@maxknv maxknv added this pull request to the merge queue Feb 2, 2025
Merged via the queue into ClickHouse:master with commit 866f236 Feb 2, 2025
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devcrafter devcrafter devcrafter approved these changes

@qoega qoega qoega approved these changes

Assignees

@devcrafter devcrafter

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

7 participants

@CurtizJ @robot-clickhouse-ci-2 @qoega @devcrafter @maxknv @robot-ch-test-poll @robot-ch-test-poll2