Skip to content

Use embedded llvm-19#75148

Merged
thevar1able merged 24 commits intomasterfrom
embedded-llvm-19
Feb 16, 2025
Merged

Use embedded llvm-19#75148
thevar1able merged 24 commits intomasterfrom
embedded-llvm-19

Conversation

@thevar1able
Copy link
Copy Markdown
Member

@thevar1able thevar1able commented Jan 28, 2025 •
edited
Loading

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Update to embedded LLVM 19.

CI Settings (Only check the boxes if you know what you are doing)

All builds in Builds_1 and Builds_2 stages are always mandatory and will run independently of the checks below:

  • Only: Stateless tests
  • Only: Integration tests
  • Only: Performance tests
  • Skip: Style check
  • Skip: Fast test
  • Run all checks ignoring all possible failures (Resource-intensive. All test jobs execute in parallel).
  • Disable CI cache

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Jan 28, 2025
@robot-ch-test-poll

This comment was marked as outdated.

Sign in to view
thevar1able
thevar1able commented Jan 28, 2025
View reviewed changes
thevar1able
thevar1able commented Jan 28, 2025
View reviewed changes
@robot-ch-test-poll robot-ch-test-poll added pr-build Pull request with build/testing/packaging improvement and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Jan 28, 2025
@geldot geldot mentioned this pull request Jan 29, 2025
Closed
rschu1ze
rschu1ze reviewed Feb 2, 2025
View reviewed changes
rschu1ze
rschu1ze approved these changes Feb 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good to me except for some submodule-related branch questions).

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Feb 12, 2025 •
edited
Loading

Workflow [PR], commit [9d467f0]

@thevar1able

This comment was marked as outdated.

Sign in to view
@thevar1able thevar1able marked this pull request as ready for review February 15, 2025 02:05
@thevar1able
Copy link
Copy Markdown
Member Author

thevar1able commented Feb 15, 2025

system_sync_replica_lightweight_from_modifier #76212

@thevar1able thevar1able added this pull request to the merge queue Feb 16, 2025
Merged via the queue into master with commit bfa660f Feb 16, 2025
116 of 118 checks passed
@thevar1able thevar1able deleted the embedded-llvm-19 branch February 16, 2025 00:36
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 16, 2025
@thevar1able thevar1able mentioned this pull request Feb 17, 2025
Merged
@nikitamikhaylov nikitamikhaylov mentioned this pull request Feb 18, 2025
Closed
@rschu1ze rschu1ze mentioned this pull request Feb 24, 2025
Merged
@alexey-milovidov alexey-milovidov mentioned this pull request May 6, 2025
Merged
yokofly added a commit to timeplus-io/proton that referenced this pull request Feb 9, 2026
@yokofly
Fix SIGSEGV in QueryThreadLog flush
f63e127 
ClientInfo stored Poco::Net::SocketAddress by value; we observed a crash in SystemLogFlush while calling SocketAddress::host() during QueryThreadLog flush. Align with upstream ClickHouse by storing current/initial addresses as std::shared_ptr and initializing them in ClientInfo ctor.

Upstream: ClickHouse/ClickHouse#75148 (commits 956b5fe90775, 94b092ebf7ad)

Tests: ClientInfo gtest for default init + serialization roundtrip.
@yokofly yokofly mentioned this pull request Feb 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschu1ze rschu1ze rschu1ze approved these changes

Assignees

@rschu1ze rschu1ze

Labels

pr-build Pull request with build/testing/packaging improvement pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thevar1able @robot-ch-test-poll @rschu1ze @robot-ch-test-poll4 @robot-clickhouse-ci-1