Add handling of SQL_TINYINT and SQL_BIGINT, fix SQL_FLOAT in ODBC Bridge#7491
Merged
akuzm merged 1 commit intoClickHouse:masterfrom Oct 28, 2019
Merged
Conversation
Fix handling of SQL_FLOAT
Contributor
|
Should we add an integration test for this? |
Contributor
We can, but with MySQL the problem with SQL_FLOAT was not reproducible, because it reports different data types. So extending MySQL integration test would not help. We've faced this issue with MSSQL. I am not sure it makes sense to have MSSQL in integration tests just for this purpose. |
Member
|
We should add integration test with MS SQL Server if the license permits: |
Member
|
The purpose of integration tests is to test as many integrations as possible. |
Member
|
But first please add integration test of ClickHouse connection to ClickHouse through its own ODBC driver. |
akuzm
added a commit
that referenced
this pull request
Oct 29, 2019
Add handling of SQL_TINYINT and SQL_BIGINT, fix SQL_FLOAT in ODBC Bridge (cherry picked from commit c3ea942)
akuzm
added a commit
that referenced
this pull request
Oct 29, 2019
Add handling of SQL_TINYINT and SQL_BIGINT, fix SQL_FLOAT in ODBC Bridge (cherry picked from commit c3ea942)
vitlibar
pushed a commit
that referenced
this pull request
Dec 26, 2019
Add handling of SQL_TINYINT and SQL_BIGINT, fix SQL_FLOAT in ODBC Bridge (cherry picked from commit c3ea942)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Add handling of SQL_TINYINT and SQL_BIGINT, and fix handling of SQL_FLOAT data source types in ODBC Bridge.