Skip to content

Fix 02597_column_update_and_replication#74826

Merged
nickitat merged 1 commit intomasterfrom
fix_02597_column_update_and_replication
Jan 28, 2025
Merged

Fix 02597_column_update_and_replication#74826
nickitat merged 1 commit intomasterfrom
fix_02597_column_update_and_replication

Conversation

@nickitat
Copy link
Copy Markdown
Member

@nickitat nickitat commented Jan 20, 2025 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

The problem explained in the comment.

Closes: #74798

CI Settings (Only check the boxes if you know what you are doing)

All builds in Builds_1 and Builds_2 stages are always mandatory and will run independently of the checks below:

  • Only: Stateless tests
  • Only: Stateful tests
  • Only: Integration tests
  • Only: Performance tests
  • Skip: Style check
  • Skip: Fast test
  • Run all checks ignoring all possible failures (Resource-intensive. All test jobs execute in parallel).
  • Disable CI cache

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 20, 2025
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Jan 20, 2025 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit efe0a56 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns ClickBench with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@serxa serxa self-assigned this Jan 20, 2025
@nickitat
Copy link
Copy Markdown
Member Author

nickitat commented Jan 28, 2025

Stateless tests (tsan, s3 storage) [2/3] - #54748

@nickitat nickitat added this pull request to the merge queue Jan 28, 2025
Merged via the queue into master with commit 3f089ed Jan 28, 2025
@nickitat nickitat deleted the fix_02597_column_update_and_replication branch January 28, 2025 21:59
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 28, 2025
azat
azat reviewed Feb 19, 2025
View reviewed changes
tests/queries/0_stateless/02597_column_update_and_replication.sql

ALTER TABLE test ADD COLUMN x UInt32 default 0;
ALTER TABLE test UPDATE x = x + 1 where 1;
ALTER TABLE test DROP COLUMN x SETTINGS mutations_sync = 2; --{serverError BAD_ARGUMENTS}
Copy link
Copy Markdown
Member

@azat azat Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial test was for checkDropCommandDoesntAffectInProgressMutations, so it looks like the test is useless now, did I missed something?

azat added a commit to azat/ClickHouse that referenced this pull request Feb 19, 2025
@azat
tests: fix 02597_column_* flakiness
1226c20 
- use throwIf() + KILL MUTATION over sleep()
- disable for SMT - it checks completelly different there, note that
  02597_column_update_tricky_expression_and_replication was not even
  tested due to test-in-test architecture of the test.

Refs: ClickHouse#74798 (@nickitat)
Refs: ClickHouse#74826 (reverts it back)
Fixes: ClickHouse#58799
azat added a commit to azat/ClickHouse that referenced this pull request Feb 19, 2025
@azat
tests: fix 02597_column_* flakiness
40041a3 
- use throwIf() + KILL MUTATION over sleep()
- disable for SMT - it checks completelly different there, note that
  02597_column_update_tricky_expression_and_replication was not even
  tested due to test-in-test architecture of the test.

Refs: ClickHouse#74798 (@nickitat)
Refs: ClickHouse#74826 (reverts it back)
Refs: ClickHouse#50181
Fixes: ClickHouse#58799
@azat azat mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azat azat azat left review comments

@serxa serxa serxa approved these changes

Assignees

@serxa serxa

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test 02597_column_update_and_replication failed

5 participants

@nickitat @robot-ch-test-poll4 @azat @serxa @robot-clickhouse-ci-2