Skip to content

Backport #73682 to 24.3: Fix several cases of queries with FINAL#74526

Merged
CurtizJ merged 1 commit into24.3from
backport/24.3/73682
Jan 14, 2025
Merged

Backport #73682 to 24.3: Fix several cases of queries with FINAL#74526
CurtizJ merged 1 commit into24.3from
backport/24.3/73682

Conversation

@robot-clickhouse
Copy link
Copy Markdown
Member

@robot-clickhouse robot-clickhouse commented Jan 13, 2025

Original pull-request #73682
Cherry-pick pull-request #74374

This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.

@robot-clickhouse robot-clickhouse added pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-bugfix Pull request with bugfix, not backported by default labels Jan 13, 2025
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jan 13, 2025 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit 4216289 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success

@Felixoid
Copy link
Copy Markdown
Member

Felixoid commented Jan 14, 2025

@CurtizJ and @Avogar, could you review the errors, please? I'd really like to spin 24.3 today, it's been a long time since it was released the last time

@CurtizJ CurtizJ merged commit 5148740 into 24.3 Jan 14, 2025
@CurtizJ CurtizJ deleted the backport/24.3/73682 branch January 14, 2025 13:31
@CurtizJ
Copy link
Copy Markdown
Member

CurtizJ commented Jan 14, 2025

@Felixoid
Something is wrong with the configuration of MongoDB in the integration test. I think it is not important and we can do a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@CurtizJ CurtizJ

@Avogar Avogar

Labels

pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@robot-clickhouse @robot-ch-test-poll @Felixoid @CurtizJ @Avogar