Allowed to have some parts on destination disk or volume in MOVE PARTITION#7434
Merged
alesapin merged 4 commits intoClickHouse:masterfrom Oct 24, 2019
excitoon-favorites:fix-7424
Merged
Allowed to have some parts on destination disk or volume in MOVE PARTITION#7434alesapin merged 4 commits intoClickHouse:masterfrom excitoon-favorites:fix-7424
alesapin merged 4 commits intoClickHouse:masterfrom
excitoon-favorites:fix-7424
Conversation
alesapin
requested changes
Oct 23, 2019
Member
alesapin
left a comment
alesapin
left a comment
There was a problem hiding this comment.
It's very easy to test with the integration test. Just move one part with ALTER TABLE MOVE PART and then try to move partition.
| } | ||
| else | ||
| { | ||
| LOG_DEBUG(log, "No parts of partition " << partition_id << " to move to disk " << disk->getName()); |
Member
There was a problem hiding this comment.
We should throw an exception here, all parts already on the destionation disk.
| } | ||
| else | ||
| { | ||
| LOG_DEBUG(log, "No parts of partition " << partition_id << " to move to volume " << volume->getName()); |
Member
There was a problem hiding this comment.
Throw exception. User should know about it.
Contributor
Author
akuzm
pushed a commit
that referenced
this pull request
Oct 29, 2019
Allowed to have some parts on destination disk or volume in MOVE PARTITION (cherry picked from commit 5d8d1df)
akuzm
pushed a commit
that referenced
this pull request
Oct 29, 2019
Allowed to have some parts on destination disk or volume in MOVE PARTITION (cherry picked from commit 5d8d1df)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Allowed to have some parts on destination disk or volume in MOVE PARTITION.
Fixes #7424