Skip to content

tests: fix test_keeper_disks/test.py::test_logs_with_disks flakiness#74197

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:tests/test_keeper_disks
Jan 6, 2025
Merged

tests: fix test_keeper_disks/test.py::test_logs_with_disks flakiness#74197
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:tests/test_keeper_disks

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jan 5, 2025

Fixes: #59547

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@azat azat force-pushed the tests/test_keeper_disks branch from 8e558d2 to 529764b Compare January 5, 2025 16:42
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 5, 2025
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jan 5, 2025 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 529764b with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@azat azat changed the title Fix test_keeper_disks/test.py::test_logs_with_disks flakiness tests: fix test_keeper_disks/test.py::test_logs_with_disks flakiness Jan 5, 2025
@azat azat added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jan 5, 2025
@alexey-milovidov alexey-milovidov self-assigned this Jan 5, 2025
@azat
Copy link
Copy Markdown
Member Author

azat commented Jan 6, 2025

Now the problem is that the test test_logs_with_disks is not idempotent, i.e. not compatible with flaky check, and it is not that easy to do this, so I would suggest to do this separately

@alexey-milovidov alexey-milovidov merged commit 47c5c4b into ClickHouse:master Jan 6, 2025
@azat azat deleted the tests/test_keeper_disks branch January 6, 2025 18:57
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 6, 2025
@jkartseva
Copy link
Copy Markdown
Member

jkartseva commented Feb 12, 2025

This test also fails in the private branches:
https://d1k2gkhrlfqv31.cloudfront.net/clickhouse-test-reports-private/25146/aaec22b580fdea0c082f4ee56493754cbbbf320f/integration_tests__tsan__[4_6].html

Should the fix be backported?

@azat
Copy link
Copy Markdown
Member Author

azat commented Feb 12, 2025

You mean backport it to 24.12 branch? Sure, let's try!

@robot-clickhouse robot-clickhouse mentioned this pull request Feb 12, 2025
Merged
robot-clickhouse added a commit that referenced this pull request Feb 12, 2025
@robot-clickhouse
Merge pull request #75967 from ClickHouse/cherrypick/24.12/74197
c2f8982 
Cherry pick #74197 to 24.12: tests: fix test_keeper_disks/test.py::test_logs_with_disks flakiness
robot-clickhouse added a commit that referenced this pull request Feb 12, 2025
@robot-clickhouse
Backport #74197 to 24.12: tests: fix test_keeper_disks/test.py::test_…
b24158c 
…logs_with_disks flakiness
@robot-clickhouse robot-clickhouse mentioned this pull request Feb 12, 2025
Merged
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created-cloud deprecated label, NOOP label Feb 12, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Feb 12, 2025
robot-ch-test-poll4 added a commit that referenced this pull request Feb 12, 2025
@robot-ch-test-poll4
Merge pull request #75968 from ClickHouse/backport/24.12/74197
7432eae 
Backport #74197 to 24.12: tests: fix test_keeper_disks/test.py::test_logs_with_disks flakiness
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_keeper_disks/test.py::test_logs_with_disks is flaky

8 participants

@azat @robot-ch-test-poll @jkartseva @alexey-milovidov @robot-clickhouse @robot-ch-test-poll2 @robot-ch-test-poll3 @robot-clickhouse-ci-2