Skip to content

Forbid to use Loop as a table engine in CREATE TABLE#74137

Merged
yariks5s merged 5 commits intoClickHouse:masterfrom
yariks5s:Loop-table-function
Jan 7, 2025
Merged

Forbid to use Loop as a table engine in CREATE TABLE#74137
yariks5s merged 5 commits intoClickHouse:masterfrom
yariks5s:Loop-table-function

Conversation

@yariks5s
Copy link
Copy Markdown
Member

@yariks5s yariks5s commented Jan 3, 2025 •
edited by rschu1ze
Loading

(motivated by #73804 (comment))

CREATE TABLE tab (uid Int16, name String, age Int16) ENGINE = Loop;

was previously giving a segfault, and it has no use, so I've fixed the segfault and forbid to use Loop as a table engine

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

It is no longer possible to use Loop as a table engine in CREATE TABLE. This combination was previously causing segfaults.

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label Jan 3, 2025
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jan 3, 2025 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit 5f7eddd with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns ClickBench with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@yariks5s yariks5s mentioned this pull request Jan 3, 2025
Merged
23 tasks
yariks5s
yariks5s commented Jan 3, 2025
View reviewed changes
@rschu1ze rschu1ze changed the title Forbid to use Loop as a table engine Forbid to use Loop as a table engine in CREATE TABLE Jan 3, 2025
rschu1ze
rschu1ze requested changes Jan 3, 2025
View reviewed changes
@rschu1ze rschu1ze self-assigned this Jan 3, 2025
rschu1ze
rschu1ze approved these changes Jan 6, 2025
View reviewed changes
@yariks5s
Copy link
Copy Markdown
Member Author

yariks5s commented Jan 7, 2025

01700_deltasum - broken on master
test_memory_limit/test.py::test_multiple_queries - broken on master
test_storage_rabbitmq - broken on master

@yariks5s yariks5s added this pull request to the merge queue Jan 7, 2025
Merged via the queue into ClickHouse:master with commit 7a4127a Jan 7, 2025
@yariks5s yariks5s deleted the Loop-table-function branch January 7, 2025 12:48
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschu1ze rschu1ze rschu1ze approved these changes

Assignees

@rschu1ze rschu1ze

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yariks5s @robot-ch-test-poll @rschu1ze @robot-ch-test-poll1