Skip to content

Disable quoting 64 bit integers in JSON formats by default#74079

Merged
Avogar merged 40 commits intoClickHouse:masterfrom
Avogar:disable-64-quoting
Aug 25, 2025
Merged

Disable quoting 64 bit integers in JSON formats by default#74079
Avogar merged 40 commits intoClickHouse:masterfrom
Avogar:disable-64-quoting

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Jan 2, 2025

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Disable quoting 64 bit integers in JSON formats by default.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing)

All builds in Builds_1 and Builds_2 stages are always mandatory
and will run independently of the checks below:

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64
  • Exclude: All with release
  • Exclude: All with debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backward-incompatible Pull request with backwards incompatible changes label Jan 2, 2025
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jan 2, 2025 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit b50a3dc with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkBuilds and tests the documentation✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@pamarcos pamarcos self-requested a review January 7, 2025 16:11
@pamarcos pamarcos self-assigned this Jan 7, 2025
@pamarcos
Copy link
Copy Markdown
Member

pamarcos commented Jan 7, 2025

What's the reasoning for this breaking change?
Also, there's a bunch of fast tests that need to be updated. Potentially more tests may fail once fast tests pass:

03272_json_to_json_cast_1 	FAIL 	0.12
03272_json_to_json_cast_3 	FAIL 	0.3
03272_json_to_json_cast_4 	FAIL 	0.12
03272_json_to_json_cast_5 	FAIL 	0.22
03274_json_to_json_alter_nested_json 	FAIL 	0.48
03287_not_comparable_types_in_order_by_and_comparison_functions

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Jan 8, 2025

What's the reasoning for this breaking change?

It was enabled by default for historical reasons. And now it causes inconsistencies in the new JSON data type. We decided to disable this setting by default now.

Also, there's a bunch of fast tests that need to be updated. Potentially more tests may fail once fast tests pass:

I will update all of them

@Avogar Avogar mentioned this pull request Jan 14, 2025
Merged
23 tasks
pamarcos
pamarcos reviewed Jan 14, 2025
View reviewed changes
@den-crane den-crane mentioned this pull request Jan 20, 2025
Closed
pamarcos
pamarcos reviewed Jan 31, 2025
View reviewed changes
@Avogar Avogar mentioned this pull request Feb 5, 2025
Closed
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Feb 14, 2025 •
edited
Loading

Workflow [PR], commit [23ec95a]

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 1, 2025

Dear @pamarcos, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.

@pamarcos pamarcos self-assigned this Jul 1, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 5, 2025

Dear @pamarcos, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.

@pamarcos pamarcos self-assigned this Aug 18, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 20, 2025 •
edited
Loading

Workflow [PR], commit [99cd120]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, sequential) failure
02962_system_sync_replica_lightweight_from_modifier FAIL
02961_drop_tables FAIL
02961_storage_config_volume_priority FAIL
02960_validate_database_engines FAIL
02960_partition_by_udf FAIL
02951_parallel_parsing_json_compact_each_row FAIL
02950_dictionary_short_circuit FAIL
02950_distributed_initial_query_event FAIL
02943_rmt_alter_metadata_merge_checksum_mismatch FAIL
02940_system_stacktrace_optimizations FAIL
02931_max_num_to_warn FAIL
02919_insert_meet_eternal_hardware_error FAIL
02918_fuzzjson_table_function FAIL
02916_another_move_partition_inactive_replica FAIL
02915_move_partition_inactive_replica FAIL
02911_support_alias_column_in_indices FAIL
02910_prefetch_unexpceted_exception FAIL
02908_empty_named_collection FAIL
02908_many_requests_to_system_replicas FAIL
02907_suggestions_readonly_user FAIL
Killed by signal (in clickhouse-server.log or clickhouse-server.err.log) FAIL
Fatal messages (in clickhouse-server.log or clickhouse-server.err.log) FAIL
Scraping part_log.2 FAIL
Stateless tests (arm_binary, parallel) failure
03364_estimate_compression_ratio FAIL
Integration tests (amd_asan, old analyzer, 6/6) failure
test_throttling/test.py::test_remote_write_throttling_reload FAIL
Stress test (amd_tsan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL
Stress test (amd_msan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Aug 24, 2025

Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, sequential) - #86050
Stateless tests (arm_binary, parallel) - #85999
Integration tests (amd_asan, old analyzer, 6/6) - #86098
Stress test (amd_tsan) - #84669
Stress test (amd_msan) - #81144

@Avogar Avogar added this pull request to the merge queue Aug 24, 2025
Merged via the queue into ClickHouse:master with commit e2b20ee Aug 25, 2025
117 of 122 checks passed
@Avogar Avogar deleted the disable-64-quoting branch August 25, 2025 00:26
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 25, 2025
@den-crane den-crane mentioned this pull request Sep 2, 2025
Closed
@den-crane
Copy link
Copy Markdown
Contributor

den-crane commented Sep 2, 2025 •
edited
Loading

For some reason it's missing in the changelog
https://clickhouse.com/docs/whats-new/changelog#258

Though it's in clickhouse/docs/changelogs/v25.8.1.5101-lts.md

Disable quoting 64 bit integers in JSON formats by default. [#74079](h....

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Sep 2, 2025

Added: #86555

@slvrtrn slvrtrn mentioned this pull request Sep 2, 2025
Merged
@den-crane den-crane mentioned this pull request Sep 2, 2025
Closed
@OverOrion OverOrion mentioned this pull request Sep 3, 2025
Merged
@Hedius Hedius mentioned this pull request Sep 7, 2025
Open
@Slach Slach mentioned this pull request Nov 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pamarcos pamarcos pamarcos left review comments

Assignees

@pamarcos pamarcos

Labels

pr-backward-incompatible Pull request with backwards incompatible changes pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Avogar @robot-ch-test-poll @pamarcos @den-crane @robot-ch-test-poll1 @robot-clickhouse-ci-1