Skip to content

Propagate Native format settings properly for client-server communication#73924

Merged
Avogar merged 5 commits intoClickHouse:masterfrom
Avogar:tcp-handler-settings
Feb 5, 2025
Merged

Propagate Native format settings properly for client-server communication#73924
Avogar merged 5 commits intoClickHouse:masterfrom
Avogar:tcp-handler-settings

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Dec 27, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Propogate Native format settings properly for client-server communication.

Closes #73883

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing)

All builds in Builds_1 and Builds_2 stages are always mandatory
and will run independently of the checks below:

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64
  • Exclude: All with release
  • Exclude: All with debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label Dec 27, 2024
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Dec 27, 2024 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit f0a1036 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (asan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (debug)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (msan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (tsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (ubsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns ClickBench with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alexey-milovidov alexey-milovidov changed the title Propogate Native format settings properly for client-server communication Propagate Native format settings properly for client-server communication Dec 28, 2024
@yakov-olkhovskiy yakov-olkhovskiy self-assigned this Dec 30, 2024
@yakov-olkhovskiy
Copy link
Copy Markdown
Member

yakov-olkhovskiy commented Dec 30, 2024

from tests - apparently there is some interference with JSON format...

@SpencerTorres SpencerTorres mentioned this pull request Jan 13, 2025
Merged
1 task
@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Jan 14, 2025 •
edited
Loading

It's because of setting output_format_native_write_json_as_string randomization and quoting of 64 bits integers by default in JSON formatting (will be updated here #74079).
I want to backport this PR to allow integrations team to use output_format_native_write_json_as_string for other languages clients with cloud versions. I will disable randomizing output_format_native_write_json_as_string. It's randomizing for a while already and no isses were found, only such noise

@SpencerTorres SpencerTorres mentioned this pull request Jan 29, 2025
Merged
1 task
@Avogar Avogar added this pull request to the merge queue Feb 5, 2025
@Avogar Avogar added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Feb 5, 2025
Merged via the queue into ClickHouse:master with commit b2f6e13 Feb 5, 2025
112 of 115 checks passed
@Avogar Avogar deleted the tcp-handler-settings branch February 5, 2025 13:13
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 5, 2025
This was referenced Feb 5, 2025
Closed
Merged
Merged
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Feb 5, 2025
@robot-ch-test-poll2
Merge pull request #75609 from ClickHouse/cherrypick/24.12/73924
1dbc02b 
Cherry pick #73924 to 24.12: Propagate Native format settings properly for client-server communication
robot-clickhouse added a commit that referenced this pull request Feb 5, 2025
@robot-clickhouse
Backport #73924 to 24.12: Propagate Native format settings properly f…
71f876c 
…or client-server communication
This was referenced Feb 5, 2025
Merged
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Feb 5, 2025
@robot-ch-test-poll2
Merge pull request #75611 from ClickHouse/cherrypick/25.1/73924
4bc70dc 
Cherry pick #73924 to 25.1: Propagate Native format settings properly for client-server communication
robot-clickhouse added a commit that referenced this pull request Feb 5, 2025
@robot-clickhouse
Backport #73924 to 25.1: Propagate Native format settings properly fo…
b192e85 
…r client-server communication
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Feb 5, 2025
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Feb 5, 2025
@robot-clickhouse-ci-2
Merge pull request #75612 from ClickHouse/backport/25.1/73924
b55f5c6 
Backport #73924 to 25.1: Propagate Native format settings properly for client-server communication
Avogar added a commit that referenced this pull request Feb 10, 2025
@Avogar
Merge pull request #75610 from ClickHouse/backport/24.12/73924
78daf9b 
Backport #73924 to 24.12: Propagate Native format settings properly for client-server communication
robot-ch-test-poll3 added a commit that referenced this pull request Feb 10, 2025
@robot-ch-test-poll3
Merge pull request #75607 from ClickHouse/cherrypick/24.8/73924
2fd59cc 
Cherry pick #73924 to 24.8: Propagate Native format settings properly for client-server communication
robot-clickhouse added a commit that referenced this pull request Feb 10, 2025
@robot-clickhouse
Backport #73924 to 24.8: Propagate Native format settings properly fo…
53257bd 
…r client-server communication
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Feb 10, 2025
Closed
robot-ch-test-poll3 added a commit that referenced this pull request Feb 10, 2025
@robot-ch-test-poll3
Merge pull request #75608 from ClickHouse/cherrypick/24.11/73924
cbf7d0e 
Cherry pick #73924 to 24.11: Propagate Native format settings properly for client-server communication
robot-clickhouse added a commit that referenced this pull request Feb 10, 2025
@robot-clickhouse
Backport #73924 to 24.11: Propagate Native format settings properly f…
0c0e1f6 
…or client-server communication
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Feb 10, 2025
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Feb 10, 2025
robot-clickhouse-ci-1 added a commit that referenced this pull request Feb 10, 2025
@robot-clickhouse-ci-1
Merge pull request #75811 from ClickHouse/backport/24.11/73924
e2ef0c5 
Backport #73924 to 24.11: Propagate Native format settings properly for client-server communication
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created-cloud deprecated label, NOOP label Feb 12, 2025
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yakov-olkhovskiy yakov-olkhovskiy yakov-olkhovskiy approved these changes

Assignees

@yakov-olkhovskiy yakov-olkhovskiy

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

output_format_native_encode_types_in_binary_format setting makes insert slow and throw error

7 participants

@Avogar @robot-clickhouse-ci-2 @yakov-olkhovskiy @robot-clickhouse @robot-ch-test-poll1 @robot-ch-test-poll4 @robot-ch-test-poll3