Skip to content

Fix optimize_read_in_order with IN and a subquery.#7371

Merged
akuzm merged 1 commit intoClickHouse:masterfrom
CurtizJ:fix-optimize-read-in-order
Oct 18, 2019
Merged

Fix optimize_read_in_order with IN and a subquery.#7371
akuzm merged 1 commit intoClickHouse:masterfrom
CurtizJ:fix-optimize-read-in-order

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Oct 17, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Bug Fix

Short description (up to few sentences):
Fix wrong query result if it has WHERE IN (SELECT ...) section and optimize_read_in_order is used.

@CurtizJ CurtizJ force-pushed the fix-optimize-read-in-order branch from 8232f14 to 546414c Compare October 17, 2019 13:12
@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Oct 18, 2019

Thread sanitizer report reproduces on master.

Copy link
Copy Markdown
Contributor

@akuzm akuzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akuzm akuzm merged commit 3143fa3 into ClickHouse:master Oct 18, 2019
@CurtizJ CurtizJ added the pr-bugfix Pull request with bugfix, not backported by default label Oct 20, 2019
@akuzm
Copy link
Copy Markdown
Contributor

akuzm commented Oct 29, 2019

backport conflict in 19.15

CurtizJ pushed a commit that referenced this pull request Nov 15, 2019
Fix optimize_read_in_order with IN and a subquery.

(cherry picked from commit 3143fa3)
CurtizJ pushed a commit that referenced this pull request Nov 15, 2019
Fix optimize_read_in_order with IN and a subquery.

(cherry picked from commit 3143fa3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants