Skip to content

Fix several cases of queries with FINAL#73682

Merged
CurtizJ merged 1 commit intoClickHouse:masterfrom
CurtizJ:fix-final-sample
Dec 24, 2024
Merged

Fix several cases of queries with FINAL#73682
CurtizJ merged 1 commit intoClickHouse:masterfrom
CurtizJ:fix-final-sample

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Dec 20, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed NOT_FOUND_COLUMN_IN_BLOCK in queries with FINAL and SAMPLE. Fixed incorrect result in selects with FINAL from CollapsingMergeTree and enabled optimizations of FINAL .

Fixes #73640.
Fixes #73118.
Fixes #72498.

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@CurtizJ CurtizJ changed the title Fix several case of queries with FINAL Fix several cases of queries with FINAL Dec 20, 2024
@CurtizJ CurtizJ mentioned this pull request Dec 20, 2024
Merged
20 tasks
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-bugfix Pull request with bugfix, not backported by default label Dec 20, 2024
@Avogar Avogar self-assigned this Dec 20, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Dec 20, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit bae8191 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@CurtizJ CurtizJ enabled auto-merge December 24, 2024 16:07
@CurtizJ CurtizJ added this pull request to the merge queue Dec 24, 2024
Merged via the queue into ClickHouse:master with commit c11dc6b Dec 24, 2024
@CurtizJ CurtizJ deleted the fix-final-sample branch December 24, 2024 17:16
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 24, 2024
@aalexfvk
Copy link
Copy Markdown
Contributor

aalexfvk commented Dec 25, 2024 •
edited
Loading

Hello! Is it possible to backport this fixes (starting from 24.3) ?

@aalexfvk
Copy link
Copy Markdown
Contributor

aalexfvk commented Jan 9, 2025

Hello, @Avogar ! Would it be possible to backport this fixes to >= 24.3 versions ?

@CurtizJ CurtizJ added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jan 9, 2025
This was referenced Jan 9, 2025
Merged
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Jan 9, 2025
@robot-ch-test-poll3
Merge pull request #74376 from ClickHouse/cherrypick/24.10/73682
e743b33 
Cherry pick #73682 to 24.10: Fix several cases of queries with `FINAL`
robot-clickhouse added a commit that referenced this pull request Jan 9, 2025
@robot-clickhouse
Backport #73682 to 24.10: Fix several cases of queries with FINAL
317b7b8
This was referenced Jan 9, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Jan 9, 2025
@robot-ch-test-poll3
Merge pull request #74378 from ClickHouse/cherrypick/24.11/73682
6d2df92 
Cherry pick #73682 to 24.11: Fix several cases of queries with `FINAL`
robot-clickhouse added a commit that referenced this pull request Jan 9, 2025
@robot-clickhouse
Backport #73682 to 24.11: Fix several cases of queries with FINAL
0c02bed
This was referenced Jan 9, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Jan 9, 2025
@robot-ch-test-poll3
Merge pull request #74380 from ClickHouse/cherrypick/24.12/73682
e415382 
Cherry pick #73682 to 24.12: Fix several cases of queries with `FINAL`
robot-clickhouse added a commit that referenced this pull request Jan 9, 2025
@robot-clickhouse
Backport #73682 to 24.12: Fix several cases of queries with FINAL
92eec1f
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Jan 9, 2025
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Jan 9, 2025
@robot-ch-test-poll4
Merge pull request #74379 from ClickHouse/backport/24.11/73682
efdec62 
Backport #73682 to 24.11: Fix several cases of queries with `FINAL`
@hanfei1991 hanfei1991 mentioned this pull request Jan 10, 2025
Closed
robot-clickhouse added a commit that referenced this pull request Jan 13, 2025
@robot-clickhouse
Merge pull request #74374 from ClickHouse/cherrypick/24.3/73682
6262a2c 
Cherry pick #73682 to 24.3: Fix several cases of queries with `FINAL`
robot-clickhouse added a commit that referenced this pull request Jan 13, 2025
@robot-clickhouse
Backport #73682 to 24.3: Fix several cases of queries with FINAL
4216289
@robot-clickhouse robot-clickhouse mentioned this pull request Jan 13, 2025
Merged
robot-clickhouse added a commit that referenced this pull request Jan 13, 2025
@robot-clickhouse
Merge pull request #74375 from ClickHouse/cherrypick/24.8/73682
ea49e3f 
Cherry pick #73682 to 24.8: Fix several cases of queries with `FINAL`
robot-clickhouse added a commit that referenced this pull request Jan 13, 2025
@robot-clickhouse
Backport #73682 to 24.8: Fix several cases of queries with FINAL
139e17a
@robot-clickhouse robot-clickhouse mentioned this pull request Jan 13, 2025
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jan 13, 2025
CurtizJ added a commit that referenced this pull request Jan 14, 2025
@CurtizJ
Merge pull request #74527 from ClickHouse/backport/24.8/73682
832432b 
Backport #73682 to 24.8: Fix several cases of queries with `FINAL`
CurtizJ added a commit that referenced this pull request Jan 14, 2025
@CurtizJ
Merge pull request #74526 from ClickHouse/backport/24.3/73682
5148740 
Backport #73682 to 24.3: Fix several cases of queries with `FINAL`
CurtizJ added a commit that referenced this pull request Jan 22, 2025
@CurtizJ
Merge pull request #74381 from ClickHouse/backport/24.12/73682
18436f2 
Backport #73682 to 24.12: Fix several cases of queries with `FINAL`
CurtizJ added a commit that referenced this pull request Jan 22, 2025
@CurtizJ
Merge pull request #74377 from ClickHouse/backport/24.10/73682
e0bf7aa 
Backport #73682 to 24.10: Fix several cases of queries with `FINAL`
@robot-clickhouse robot-clickhouse added the pr-backports-created-cloud deprecated label, NOOP label Feb 13, 2025
@cwurm cwurm mentioned this pull request Feb 14, 2025
Closed
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avogar Avogar Avogar approved these changes

Assignees

@Avogar Avogar

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

7 participants

@CurtizJ @robot-ch-test-poll1 @aalexfvk @Avogar @robot-clickhouse @robot-ch-test-poll4 @robot-clickhouse-ci-2