Better ambiguous column detection#7358
Merged
4ertus2 merged 12 commits intoClickHouse:masterfrom Oct 24, 2019
Merged
Conversation
4ertus2
commented
Oct 18, 2019
| if (!join || !join->table_expression) | ||
| return; | ||
|
|
||
| /// TODO: Push down for CROSS JOIN is not OK [disabled] |
Contributor
Author
There was a problem hiding this comment.
I've also disabled table to subquery rewrite logic for CROSS JOINs here cause it doesn't work properly.
Contributor
|
|
akuzm
reviewed
Oct 24, 2019
akuzm
reviewed
Oct 24, 2019
akuzm
reviewed
Oct 24, 2019
akuzm
approved these changes
Oct 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Detect and throw if we cannot detect table for column name in query.