Skip to content

Revert "Enable JIT compilation for more expressions"#73010

Merged
Algunenano merged 1 commit intomasterfrom
revert-70598-more_jits
Dec 10, 2024
Merged

Revert "Enable JIT compilation for more expressions"#73010
Algunenano merged 1 commit intomasterfrom
revert-70598-more_jits

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Dec 10, 2024

Reverts #70598

Crashes have been found by fuzzers

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 10, 2024
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Dec 10, 2024 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit fb02bec with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@rschu1ze
Copy link
Copy Markdown
Member

rschu1ze commented Dec 10, 2024

Example crash: https://s3.amazonaws.com/clickhouse-test-reports/0/e26fb09d0038fe9af8f45fc942864aae5c54bd88/ast_fuzzer__ubsan_/main.log

@Algunenano Algunenano enabled auto-merge December 10, 2024 13:56
@Algunenano Algunenano added this pull request to the merge queue Dec 10, 2024
Merged via the queue into master with commit 8999fdd Dec 10, 2024
@Algunenano Algunenano deleted the revert-70598-more_jits branch December 10, 2024 15:15
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 10, 2024
@taiyang-li taiyang-li mentioned this pull request Dec 18, 2024
Closed
21 tasks
@taiyang-li
Copy link
Copy Markdown
Contributor

taiyang-li commented Dec 20, 2024

Example crash: https://s3.amazonaws.com/clickhouse-test-reports/0/e26fb09d0038fe9af8f45fc942864aae5c54bd88/ast_fuzzer__ubsan_/main.log

It is fixed in #73509.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Algunenano @robot-clickhouse @rschu1ze @taiyang-li @robot-clickhouse-ci-1 @robot-clickhouse-ci-2