Skip to content

Support equal comparison for JSON column#72991

Merged
vdimir merged 3 commits intoClickHouse:masterfrom
Avogar:json-equal-comparison
Dec 12, 2024
Merged

Support equal comparison for JSON column#72991
vdimir merged 3 commits intoClickHouse:masterfrom
Avogar:json-equal-comparison

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Dec 9, 2024 •
edited
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Support equal comparison for values of JSON column.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@Avogar Avogar mentioned this pull request Dec 9, 2024
Open
56 tasks
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-performance Pull request with some performance improvements label Dec 9, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Dec 9, 2024 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit 39d687f with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vdimir vdimir self-assigned this Dec 10, 2024
vdimir
vdimir reviewed Dec 10, 2024
View reviewed changes
tests/queries/0_stateless/03282_json_equal_comparison.sql Outdated
{"json1" : {"a" : 42, "b" : 42, "c" : 42, "d" : 42, "e" : 42}, "json2" : {"a" : 42, "b" : 42, "d" : 42, "c" : 42, "e" : "42"}}
{"json1" : {"a" : 42, "b" : 42, "c" : 42, "d" : 42, "e" : 42}, "json2" : {"a" : 42, "b" : 42, "d" : 42, "c" : 42, "e" : 42.0}};

select json1, json2, json1 == json2 from test;
Copy link
Copy Markdown
Member

@vdimir vdimir Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we compare for inequality?

Copy link
Copy Markdown
Member

@vdimir vdimir Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it's worth adding cases with other operators (expecting error or whatever)

Copy link
Copy Markdown
Member Author

@Avogar Avogar Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we compare for inequality?

Yes, I will add tests for it as well.

Copy link
Copy Markdown
Member Author

@Avogar Avogar Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test for inequality.

Also it's worth adding cases with other operators (expecting error or whatever)

I will make a separate PR with tests when I add an error for other operators as a backward incompatible change under a setting

Copy link
Copy Markdown
Member Author

@Avogar Avogar Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#73276

src/Columns/ColumnObject.h
void updatePermutation(PermutationSortDirection, PermutationSortStability, size_t, int, Permutation &, EqualRanges &) const override {}

/// Values of ColumnObject are not comparable.
/// Values of ColumnObject are not comparable for less and greater functions.
Copy link
Copy Markdown
Member

@vdimir vdimir Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we force it somewhere, so other operators shows proper error?

Copy link
Copy Markdown
Member Author

@Avogar Avogar Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no, for not comparable types like JSON/Object/AggregateFunction/SimpleAggregateFunction we just fallback to generic implementation of less/greater/etc functions that uses IColumn::compareAt (and for these types it always returns 0 except JSON now that returns 0 for equal and 1 for all other cases).

I would change it and throw an exception in functions less/greater/etc if type is not comparable. And maybe in ORDER BY as well. But it will be backward incompatible change, so let me do it in a separate PR under a setting.

@vdimir
Copy link
Copy Markdown
Member

vdimir commented Dec 10, 2024

Is Performance Improvement expected category for the PR

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Dec 11, 2024

Is Performance Improvement expected category for the PR

No, it was a mistake. Changed it to just Improvement

@Avogar Avogar added pr-improvement Pull request with some product improvements and removed pr-performance Pull request with some performance improvements labels Dec 11, 2024
@vdimir vdimir added this pull request to the merge queue Dec 12, 2024
Merged via the queue into ClickHouse:master with commit eb1d7bd Dec 12, 2024
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdimir vdimir vdimir left review comments

Assignees

@vdimir vdimir

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Avogar @robot-ch-test-poll1 @vdimir @robot-ch-test-poll @robot-clickhouse-ci-2