uniqCombined memory usage tests fixes#7270
Merged
KochetovNicolai merged 3 commits intoClickHouse:masterfrom Oct 10, 2019
Merged
uniqCombined memory usage tests fixes#7270KochetovNicolai merged 3 commits intoClickHouse:masterfrom
KochetovNicolai merged 3 commits intoClickHouse:masterfrom
Conversation
…ined(12)(String) In e373862 the maxium size for HashTable in CombinedCardinalityEstimator had been reduced for power of 2 for String (since otherwise the size of the hashtable becames bigger then the sizeof HLL). Refs: ClickHouse#7236 (comment) Fixes: e373862 ("Do not use more then 98K of memory for uniqCombined*")
KochetovNicolai
approved these changes
Oct 10, 2019
KochetovNicolai
added
the
pr-build
alexey-milovidov
approved these changes
Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR conflicts with #7266, but it breaks 00212_shard_aggregate_function_uniq into logical sections
Category (leave one):
Short description (up to few sentences):
Fix
00212_shard_aggregate_function_uniqafter changes in #7236.