Skip to content

Support subcolumns in MergeTree sorting key and skip indexes#72644

Merged
Avogar merged 10 commits intoClickHouse:masterfrom
Avogar:order-by-subcolumns
Dec 17, 2024
Merged

Support subcolumns in MergeTree sorting key and skip indexes#72644
Avogar merged 10 commits intoClickHouse:masterfrom
Avogar:order-by-subcolumns

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Nov 29, 2024

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Support subcolumns in MergeTree sorting key and skip indexes.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@Avogar Avogar mentioned this pull request Nov 29, 2024
Open
56 tasks
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-improvement Pull request with some product improvements label Nov 29, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Nov 29, 2024 •
edited
Loading

This is an automated comment for commit d028426 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Nov 29, 2024

Don't look at the number of changed lines, the chages in code are only 236 lines, the rest are tests reference files

@CurtizJ CurtizJ self-assigned this Dec 2, 2024
CurtizJ
CurtizJ reviewed Dec 3, 2024
View reviewed changes
@Avogar Avogar requested a review from CurtizJ December 5, 2024 17:49
@Avogar Avogar enabled auto-merge December 17, 2024 15:08
@Avogar Avogar added this pull request to the merge queue Dec 17, 2024
Merged via the queue into ClickHouse:master with commit 73c2ccf Dec 17, 2024
@Avogar Avogar deleted the order-by-subcolumns branch December 17, 2024 16:04
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Dec 17, 2024
Merged
robot-ch-test-poll added a commit that referenced this pull request Dec 17, 2024
@robot-ch-test-poll
Merge pull request #73471 from ClickHouse/cherrypick/24.12/72644
1441be2 
Cherry pick #72644 to 24.12: Support subcolumns in MergeTree sorting key and skip indexes
robot-clickhouse added a commit that referenced this pull request Dec 17, 2024
@robot-clickhouse
Backport #72644 to 24.12: Support subcolumns in MergeTree sorting key…
9884cc9 
… and skip indexes
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Dec 17, 2024
Merged
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 17, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 17, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created-cloud deprecated label, NOOP label Dec 17, 2024
PedroTadim
PedroTadim reviewed Dec 17, 2024
View reviewed changes
tests/queries/0_stateless/03277_json_subcolumns_in_primary_key.sql.j2

set optimize_read_in_order=1;
set allow_experimental_json_type=1;
set allow_experimental_variant_type=1;
Copy link
Copy Markdown
Member

@PedroTadim PedroTadim Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the variant type being enabled here, but I don't see it being used in the tests?

Copy link
Copy Markdown
Member Author

@Avogar Avogar Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's needed to run this type of query:

insert into test select number, toJSONString(map('a', number % 2, 'b', 'str_' || number % 3, 'c', range(number % 10))), 'Hello, World!' from numbers(4);

By default it will not be able to create such map with an exception:

There is no supertype for types UInt8, String, Array(UInt8)

But with use_variant_as_common_type=1 and allow_experimental_variant_type=1 it will return Map with type Map(String, Variant(Array(UInt8), String, UInt8)). It's just easier to create a JSON with paths with different types this way

robot-clickhouse-ci-2 added a commit that referenced this pull request Dec 17, 2024
@robot-clickhouse-ci-2
Merge pull request #73472 from ClickHouse/backport/24.12/72644
0e659c9 
Backport #72644 to 24.12: Support subcolumns in MergeTree sorting key and skip indexes
@pakud pakud mentioned this pull request Dec 21, 2024
Closed
Avogar added a commit that referenced this pull request Dec 24, 2024
@Avogar
Update CHANGELOG.md to account for #72644
5af0ba1
github-merge-queue bot pushed a commit that referenced this pull request Dec 24, 2024
@nikitamikhaylov
Merge pull request #73785 from ClickHouse/Avogar-patch-7
5633959 
Update CHANGELOG.md to account for #72644
@KochetovNicolai KochetovNicolai mentioned this pull request Feb 24, 2025
Merged
1 task
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PedroTadim PedroTadim PedroTadim left review comments

@CurtizJ CurtizJ CurtizJ approved these changes

Assignees

@CurtizJ CurtizJ

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-improvement Pull request with some product improvements pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Avogar @robot-ch-test-poll4 @PedroTadim @CurtizJ @robot-clickhouse @robot-ch-test-poll @robot-ch-test-poll3 @robot-clickhouse-ci-2