Skip to content

Disable memory tracker for exception stack.#7264

Merged
KochetovNicolai merged 3 commits intomasterfrom
disable-memory-tracker-for-stack-trace
Oct 10, 2019
Merged

Disable memory tracker for exception stack.#7264
KochetovNicolai merged 3 commits intomasterfrom
disable-memory-tracker-for-stack-trace

Conversation

@KochetovNicolai
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai commented Oct 10, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Improvement

Short description (up to few sentences):
Disable memory tracker while converting exception stack trace to string. It can prevent swallowing exception of type Memory limit exceeded by server (which causes Attempt to read after eof exception on client.)

Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See TG chat.

@KochetovNicolai KochetovNicolai added the pr-bugfix Pull request with bugfix, not backported by default label Oct 10, 2019
@KochetovNicolai KochetovNicolai merged commit 9a89ee8 into master Oct 10, 2019
akuzm pushed a commit that referenced this pull request Oct 29, 2019
…tack-trace

Disable memory tracker for exception stack.

(cherry picked from commit 9a89ee8)
CurtizJ pushed a commit that referenced this pull request Nov 15, 2019
…tack-trace

Disable memory tracker for exception stack.

(cherry picked from commit 9a89ee8)
@CurtizJ CurtizJ added the v19.14 label Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants