Fix bad code in transforming query for external database.#7252
Merged
alexey-milovidov merged 3 commits intomasterfrom Oct 10, 2019
Merged
Conversation
alexey-milovidov
added
pr-bugfix
4ertus2
reviewed
Oct 10, 2019
| class ReplacingConstantExpressionsMatcher | ||
| { | ||
| public: | ||
| using Data = Block; |
Contributor
There was a problem hiding this comment.
Interesting hack. I've never thought about assigning Data to a real class.
Member
Author
There was a problem hiding this comment.
I didn't consider it as hack. I have just read ActionsVisitor and have thought that it's the intended way of usage.
akuzm
pushed a commit
that referenced
this pull request
Oct 29, 2019
…ery-for-external-database Fix bad code in transforming query for external database. (cherry picked from commit 9c1c596)
CurtizJ
pushed a commit
that referenced
this pull request
Nov 15, 2019
…ery-for-external-database Fix bad code in transforming query for external database. (cherry picked from commit 9c1c596)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Fixed constant expressions folding for external database engines (MySQL, ODBC, JDBC). In previous versions it wasn't working for multiple constant expressions and was not working at all for Date, DateTime and UUID. This fixes #7245