Conversation
vitlibar
force-pushed
the
RBAC-1
branch
13 times, most recently
from
2ba6859 to
3aae6aa
Compare
vitlibar
force-pushed
the
RBAC-1
branch
2 times, most recently
from
5bb3333 to
5796f00
Compare
dbms/src/Access/Authentication.h
Outdated
There was a problem hiding this comment.
Looks like unneeded for public interface.
There was a problem hiding this comment.
Looks like unneeded for public interface.
The public function getPasswordHashBinary() is already used by MySQLProtocol. I suppose the setPasswordHashBinary() can be public too for consistency.
dbms/src/Access/Authentication.h
Outdated
There was a problem hiding this comment.
According to the usage pattern, I suggest to set type and password only once in constructor - and interpret the password string according to type.
dbms/src/Access/AllowedClientHosts.h
Outdated
dbms/src/Access/AllowedClientHosts.h
Outdated
There was a problem hiding this comment.
I suggest to remove this method from interface - passing user_name can be replaced with outer call to contains() where the username is known.
There was a problem hiding this comment.
I suggest to remove this method from interface - passing
user_namecan be replaced with outer call tocontains()where the username is known.
The code generating an error message for that purpose isn't very simple, and I'd like to keep this kind of details inside this specific AllowedClientHosts class, not inside the more generic class User (which has other work to do).
3 participants
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
Just refactoring in order to implement RBAC, no new functionality here.