Skip to content

Revert "Short circuit optimization for functions executed over Nullable arguments"#72258

Merged
Algunenano merged 1 commit intomasterfrom
revert-60129-short_circut_func
Nov 22, 2024
Merged

Revert "Short circuit optimization for functions executed over Nullable arguments"#72258
Algunenano merged 1 commit intomasterfrom
revert-60129-short_circut_func

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Nov 22, 2024

Reverts #60129

Degrades performance

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 22, 2024
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Nov 22, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit 19dd88c with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@Algunenano Algunenano enabled auto-merge November 22, 2024 15:07
@Algunenano Algunenano added this pull request to the merge queue Nov 22, 2024
Merged via the queue into master with commit 2af2d11 Nov 22, 2024
@Algunenano Algunenano deleted the revert-60129-short_circut_func branch November 22, 2024 15:48
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 22, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Nov 22, 2024
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Nov 22, 2024
@robot-clickhouse-ci-2
Merge pull request #72288 from ClickHouse/cherrypick/24.11/72258
3196e00 
Cherry pick #72258 to 24.11: Revert "Short circuit optimization for functions executed over Nullable arguments"
robot-clickhouse added a commit that referenced this pull request Nov 22, 2024
@robot-clickhouse
Backport #72258 to 24.11: Revert "Short circuit optimization for func…
48b7d5f 
…tions executed over Nullable arguments"
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Nov 22, 2024
Merged
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created-cloud deprecated label, NOOP label Nov 22, 2024
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 22, 2024
Algunenano added a commit that referenced this pull request Nov 22, 2024
@Algunenano
Merge pull request #72289 from ClickHouse/backport/24.11/72258
476592b 
Backport #72258 to 24.11: Revert "Short circuit optimization for functions executed over Nullable arguments"
@taiyang-li taiyang-li mentioned this pull request Dec 25, 2024
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Algunenano @robot-ch-test-poll3 @robot-ch-test-poll @robot-ch-test-poll2