Include Field.h and FieldVisitor.h into fewer files.#7212
Merged
alexey-milovidov merged 3 commits intomasterfrom Oct 8, 2019
Merged
Include Field.h and FieldVisitor.h into fewer files.#7212alexey-milovidov merged 3 commits intomasterfrom
alexey-milovidov merged 3 commits intomasterfrom
Conversation
Move the methods of SettingsCollection<> that are dependent on Field to a separate file, and include it once for each instantiation. This allows to work on Field without always recompiling the entire project.
akuzm
changed the title
| #include "PerformanceTestInfo.h" | ||
| #include <Common/getMultipleKeysFromConfig.h> | ||
| #include <Common/SettingsChanges.h> | ||
| #include <Common/SettingsChanges.h> /// |
Member
There was a problem hiding this comment.
Empty commit is better way to trigger CI.
Collaborator
There was a problem hiding this comment.
--amend with simple changes to commit messages is another way. (empty commits might lead to weird git history)
alexey-milovidov
approved these changes
Oct 7, 2019
akuzm
force-pushed
the
aku/field-includes
branch
from
8514054 to
9355e5f
Compare
akuzm
force-pushed
the
aku/field-includes
branch
from
9355e5f to
2b30f26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a part of #7179. I am merging it separately for the ease of backporting, so that the other PR contains only the bug fix.
Category (leave one):
Short description (up to few sentences):
Optimize some header files for faster rebuilds.