Added cache for primary index#72102
Merged
alesapin merged 8 commits intoClickHouse:masterfrom Nov 26, 2024
Merged
Conversation
Contributor
|
This is an automated comment for commit eadcde4 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
CurtizJ
force-pushed
the
primary-index-cache
branch
from
e910d18 to
ffc4d26
Compare
CurtizJ
force-pushed
the
primary-index-cache
branch
from
ffc4d26 to
7881ae2
Compare
Member
Author
|
Fuzzer: #72265. |
Member
|
0_o |
Member
|
o_O |
alesapin
approved these changes
Nov 26, 2024
|
|
||
| IMergeTreeDataPart::IndexPtr IMergeTreeDataPart::loadIndexToCache(PrimaryIndexCache & index_cache) const | ||
| { | ||
| auto key = PrimaryIndexCache::hash(getDataPartStorage().getFullPath()); |
Member
There was a problem hiding this comment.
Maybe to a comment somewhere, what we use as a key for cache, but it's clear.
robot-ch-test-poll4
added
the
pr-synced-to-cloud
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Nov 27, 2024
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Nov 28, 2024
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Nov 28, 2024
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Nov 28, 2024
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Nov 29, 2024
baibaichen
added a commit
to apache/gluten
that referenced
this pull request
Nov 30, 2024
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241129) * Fix Build AND UT Due to [Added cache for primary index](ClickHouse/ClickHouse#72102) * Fix Build and UT due to [no auto write buffer finalization in destructors](ClickHouse/ClickHouse#68800) - Make LocalPartitionWriter::evictPartitions called, e.g. set(GlutenConfig.COLUMNAR_CH_SHUFFLE_SPILL_THRESHOLD.key, (1024*1024).toString) * Fix Build due to [Save several minutes of build time](ClickHouse/ClickHouse#72046) * Fix Benchmark Build due to [Scatter blocks in hash join without copying](ClickHouse/ClickHouse#67782) (cherry picked from commit 8d566d6a8b8785e4072ffd6f774eb83b07ac3d8d) * Fix Benchmark Build * Fix endless loop due to ClickHouse/ClickHouse#70598 * [Refactor #8100] using CHConf.setCHConfig() * fix style --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang Chen <[email protected]>
KochetovNicolai
added a commit
that referenced
this pull request
Oct 29, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
…e-in-projection-analysis Fix potential heap-use-after-free in projections analysis after #72102
robot-clickhouse
added a commit
that referenced
this pull request
Nov 4, 2025
…ions analysis after #72102
robot-clickhouse
added a commit
that referenced
this pull request
Nov 4, 2025
…ions analysis after #72102
robot-clickhouse
added a commit
that referenced
this pull request
Nov 4, 2025
…ions analysis after #72102
robot-clickhouse
added a commit
that referenced
this pull request
Nov 4, 2025
…tions analysis after #72102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added cache for primary index of
MergeTreetables (can be enabled by table settinguse_primary_key_cache). If lazy load and cache are enabled for primary index, it will be loaded to cache on demand (similar to mark cache) instead of keeping it in memory forever. Added prewarm of primary index on inserts/mergs/fetches of data parts and on restarts of table (can be enabled by settingprewarm_primary_key_cache).Resolves #71992.
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):