Conversation
| @@ -0,0 +1,164 @@ | |||
| #include <Parsers/ASTDictionary.h> | |||
There was a problem hiding this comment.
I thought that we can parse free-form syntax, convert to DOM and re-use existing code.
There was a problem hiding this comment.
It can be better, because source can has custom properties depending on the source itself.
There was a problem hiding this comment.
Yes, I also plan to convert AST to DOM (Poco::AbstractConfiguration) and reuse the current code in the ExternalLoader. But I don't want to make parser absolutely free-form because dictionaries have concrete structure. SOURCE is the only section where we have absolutely custom properties and it's already represented as function with key-value arguments which can hold any amount of custom properties (also nested).
Or you mean some general conversion function from AST to DOM? I don't think that it's necessary, because all sections except source can be converted straightforward.
|
Docs check failed on master |
|
Do we need any docs here? |
4 participants
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Parser for dictionaries DDL without any semantic.