Skip to content

Get rid of the legacy mongodb integration#71997

Merged
rschu1ze merged 10 commits intoClickHouse:masterfrom
allmazz:delete_old_mongodb_integration
Nov 26, 2024
Merged

Get rid of the legacy mongodb integration#71997
rschu1ze merged 10 commits intoClickHouse:masterfrom
allmazz:delete_old_mongodb_integration

Conversation

@allmazz
Copy link
Copy Markdown
Contributor

@allmazz allmazz commented Nov 15, 2024 •
edited by rschu1ze
Loading

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

The legacy MongoDB integration based on the Poco driver has been removed. Server setting use_legacy_mongodb_integration is obsolete and has no effect anymore.

This was referenced Nov 15, 2024
Merged
Open
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Nov 15, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backward-incompatible Pull request with backwards incompatible changes label Nov 15, 2024
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented Nov 15, 2024 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit 934ae95 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

nikitamikhaylov
nikitamikhaylov reviewed Nov 17, 2024
View reviewed changes
@rschu1ze rschu1ze self-assigned this Nov 25, 2024
@rschu1ze
Copy link
Copy Markdown
Member

rschu1ze commented Nov 26, 2024

ClickHouse Stateless tests (ubsan) [2/2]: #72008

@rschu1ze rschu1ze enabled auto-merge November 26, 2024 21:51
@rschu1ze rschu1ze added this pull request to the merge queue Nov 26, 2024
Merged via the queue into ClickHouse:master with commit e9f083b Nov 26, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 26, 2024
Algunenano
Algunenano reviewed Dec 12, 2024
View reviewed changes
src/Core/ServerSettings.cpp
DECLARE(UInt64, parts_killer_pool_size, 128, "Threads for cleanup of shared merge tree outdated threads. Only available in ClickHouse Cloud", 0) \
DECLARE(UInt64, keeper_multiread_batch_size, 10'000, "Maximum size of batch for MultiRead request to [Zoo]Keeper that support batching. If set to 0, batching is disabled. Available only in ClickHouse Cloud.", 0) \
DECLARE(Bool, use_legacy_mongodb_integration, true, "Use the legacy MongoDB integration implementation. Note: it's highly recommended to set this option to false, since legacy implementation will be removed in the future. Please submit any issues you encounter with the new implementation.", 0) \
DECLARE(Bool, use_legacy_mongodb_integration, true, "Obsolete, has no effect", 0) \
Copy link
Copy Markdown
Member

@Algunenano Algunenano Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the description to say it's obsolete does nothing. You need to change the flags themselves

@rschu1ze rschu1ze mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano left review comments

@nikitamikhaylov nikitamikhaylov nikitamikhaylov left review comments

@rschu1ze rschu1ze rschu1ze left review comments

Assignees

@rschu1ze rschu1ze

Labels

can be tested Allows running workflows for external contributors pr-backward-incompatible Pull request with backwards incompatible changes pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@allmazz @robot-ch-test-poll2 @rschu1ze @Algunenano @nikitamikhaylov @alexey-milovidov @robot-ch-test-poll1 @robot-ch-test-poll3