Skip to content

Conversation

@yariks5s
Copy link
Member

@yariks5s yariks5s commented Nov 14, 2024

Closes #30935

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Implements new data types: Time (HHH:MM:SS) and Time64 (HHH:MM:SS.<fractional>) and some basic cast functions and functions to interact with other data types. Also, changed the existing function's name toTime to toTimeWithFixedDate because the function toTime is required for the cast function.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug

  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers

  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-feature Pull request with new product feature label Nov 14, 2024
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented Nov 14, 2024

This is an automated comment for commit 0a4ace9 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report❌ failure

@yariks5s yariks5s marked this pull request as draft December 4, 2024 17:20
@alexey-milovidov alexey-milovidov mentioned this pull request Dec 31, 2024
76 tasks
@clickhouse-gh
Copy link

clickhouse-gh bot commented Feb 4, 2025

Dear @yariks5s, this PR hasn't been updated for a while. Will you continue working on it? If not, please close it. Otherwise, ignore this message.

@clickhouse-gh
Copy link

clickhouse-gh bot commented Apr 29, 2025

Dear @yariks5s, this PR hasn't been updated for a while. Will you continue working on it? If not, please close it. Otherwise, ignore this message.

github-merge-queue bot pushed a commit that referenced this pull request May 8, 2025
Implement Time and Time64 data types, #71943
@yariks5s
Copy link
Member Author

Implemented in #75735

@yariks5s yariks5s closed this May 21, 2025
@yariks5s yariks5s deleted the time_time64 branch May 21, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature Pull request with new product feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Time (32)/Time64 datatype

4 participants